cidaas / cidaas-sdk-ios-v2 Goto Github PK

I'm attempting to integrate your SDK with SwiftUI and have encountered challenges with web view integration. As per my observations, instantiating a CidaasView without utilizing a storyboard seems to be problematic.

Could you kindly furnish a solution or guidelines for SwiftUI compatibility?

If a user logged in with an app using the old Cidaas SDK and then update to a version with the new Cidaas SDK, it will crash.

The problem is the function accessTokenModelToAccessTokenEntity:

One line was was changed from:
AccessTokenModel.shared.refresh_token = accessTokenEntity.refresh_token
to:
AccessTokenModel.shared.refresh_token = try! accessTokenEntity.refresh_token.aesEncrypt(key: key, iv: salt)

There is no fallback for old user data without encryption, and there is no error handling either. It just crashes.

The same seems to be true for access_token

Hi!

May you provide this sdk through Swift Package Manager, please?

The token refresh is broken, because "accessTokenModel.refresh_token" is still encrypted when using in "self.getAccessToken(refreshToken: ..."
It's only uncoded in "accessTokenModelToAccessTokenEntity"

`
public func getAccessToken(sub: String, callback: @escaping (Result) -> Void) {

    // getting current seconds
    let milliseconds = Date().timeIntervalSince1970
    let seconds = Int64(milliseconds)
    
    let accessTokenModel = DBHelper.shared.getAccessToken(key: sub)
    let expires = accessTokenModel.expires_in
    let secs: Int64 = Int64(accessTokenModel.seconds)
    let expires_in = expires + secs - 10
    
    if expires_in > seconds {
        
        if String(seconds).count < 10 {
            self.getAccessToken(refreshToken: accessTokenModel.refresh_token, callback: callback)
            return
        }
        
        EntityToModelConverter.shared.accessTokenModelToAccessTokenEntity(accessTokenModel: accessTokenModel) { (accessTokenEntity) in
            // return success callback
            let response = LoginResponseEntity()
            response.success = true
            response.status = 200
            response.data = accessTokenEntity
            
            DispatchQueue.main.async {
                callback(Result.success(result: response))
            }
            return
        }
    }
        
    else {
        self.getAccessToken(refreshToken: accessTokenModel.refresh_token, callback: callback)
    }
}

`

The Cidaas API returns data in utf8, which is good, but it doesn't specify this in the response headers. The default parser in the SDK (in Alamofire) is some old ISO standard, so utf8 strings with special characters are parsed incorrectly.
At least the SDK should set the correct encoding. Even better would be, if the API sent the charset in its response headers.