Unable to highlight a specific object option about ember-power-select HOT 6 CLOSED

@rogeraraujo90 if you want you can add a PR for your requests

from ember-power-select.

Hi @rogeraraujo90 thanks for reporting...

Can you provide an example in which case it dosn't match? So we can add a test and fix it.

from ember-power-select.

Hi @mkszepp, I have group options like that:

class TimePickerOption {
  constructor(group, value) {
    this.group = group;
    this.value = value;
  }

  isEqual(other) {
    return this.group === other?.group && this.value === other?.value;
  }
}

const options = [{
  groupName: "period",
    options: [
      new TimePickerOption("Period", "AM" ),
      new TimePickerOption("Period", "PM" ),
    ]
}]

Given these options, if I try to highlight the option with the value "PM", the isEqual method is not called. Internally, we do the entry === option, which will always return false. If replacing by isEqual(entry, option), this would work.

I was trying to highlight the option by doing:

eps.actions.highlight(new TimePickerOption(PERIOD_GROUP, period));

Let me know if you need more info!

from ember-power-select.

Hey, just noticed that, due to a similar cause, the aria-current is not properly defined as "true". We need a logic similar what we have for aria-selected here.

from ember-power-select.

Let me know if I can help with the fix! I'm using EPS in a new feature in my project :)

from ember-power-select.

@rogeraraujo90 if you want you can add a PR for your requests

I just opened the PR!

from ember-power-select.