chriswill / dbupreboot Goto Github PK

First kudos for all the efforts to date to bring DbUp to a more modern stack. DbUp is a fantastic tool. :-)
Microsoft.Azure.Services.AppAuthentication is no longer recommended and Azure.Identity should be used instead per Microsoft - see https://docs.microsoft.com/en-us/dotnet/api/overview/azure/app-auth-migration. We are on an endless upgrade treadmill! ;-)

Migrating to the new library would also make it possible to enhance DbUpReboot to support user-assigned managed identities (passwordless service principals) in Azure. This provides significant security benefits as no sensitive credentials are ever used, andna managed identity can only be used from inside Azure itself.
Currently the AzureSqlConnectionManager uses AzureServiceTokenProvider which does not have a way to pass in the ClientID of a managed identity.
It would be awesome if these enhancements could be made as this would make it possible to run DbUp migrations either from an Azure Container Instance or from a job in Azure Kubernetes Service.

https://security.snyk.io/vuln/SNYK-DOTNET-SYSTEMDRAWINGCOMMON-3063427

No immediate resolution available due to dependency on Microsoft.Data.SqlClient

DbUp currently allows the caller to specify an AzureDatabaseEdition.

Ideally, it would be good to allow finer control over this by accepting a parameter specifying the Service Objective (e.g. S0, etc).

At it's simplest, this could be an optional string argument passed to SqlDatabase() - alternatively, an enum similar to AzureDatabaseEdition might be a better DX (although would probably add maintenance overhead if MS changes SKUs).

This would ultimately mean that the DbUp command would change from:

create database [mydatabase] ( EDITION = 'standard' );

to:

create database [mydatabase] ( EDITION = 'standard', SERVICE_OBJECTIVE = 'S0' );

when a service objective parameter is supplied.

I am happy to raise a PR for this, but wanted to gauge interest / opinions first.

Hello,

We have just started to use your DbUp fork and it is great because of the Microsoft.Data.SqlClient support

Do you have plan to upgrade to 3.0.0?

https://docs.microsoft.com/en-us/sql/connect/ado-net/sql/azure-active-directory-authentication?view=sql-server-ver15