chrisguitarguy / requestidbundle Goto Github PK

Since commit 26247af introduced a requirement for Twig, such requirement should be explicit.
Unfortunately, the commit only changed require-dev section, that is working only when this repository is used standalone (e.g. in testing).
For requirement to be enforced when this repository is used as a dependency, the following section should be added:

"conflict": {
    "twig/twig": "<1.38|>=2,<2.7"
}

Decide which services to make public, namely.

Could we tag 4.0 ? composer validate --strict doesn't seem to like the RC tag, and I think it's stable (enough ?) for an actual release.

Hello, nice bundle.

How about generating request ID for console commands too?

The various Twib_* classes are deprecated in Twig 2.7.

This one is tricky because we don't actually require twig in composer.json but support if if present. Right now we use Twig_Extension and Twig_SimpleFunction.

Maybe just erroring here if they don't exist and people are requesting twig? v1.34 introduced the aliased classes.

After updating Symfony to 5.3, I've got a log of deprecated warning : Symfony\Component\HttpKernel\Event\KernelEvent::isMasterRequest()" is deprecated, use "isMainRequest()

After analyzing the call stack, it's from the request-id bundle.
It's seem only come from the src/EventListener/RequestIdListener.php file : https://github.com/chrisguitarguy/RequestIdBundle/search?q=isMasterRequest

Hello

To reproduce bug try following commands:

Create a new project composer create-project symfony/skeleton request-id-bundle-example
Install monolog composer require monolog
Install bundle composer require chrisguitarguy/request-id-bundle
Configure this bundle (enable integration with Monolog).

On PHP 8.1 you should get an error, when you try to access /

Chrisguitarguy\RequestId\Monolog\RequestIdProcessor::__invoke(): Argument #1 ($record) must be of type array, Monolog\LogRecord given, called in /home/marcin/projekty/requestidbundle-test/vendor/monolog/monolog/src/Monolog/Logger.php on line 331

Monolog 3 requires PHP 8.1, but also has introduced some changes in API - UPGRADE instructions for Monolog 3

Log records have been converted from an array to a Monolog\LogRecord object with public (and mostly readonly) properties. e.g. instead of doing $record['context'] use $record->context. In formatters or handlers if you rather need an array to work with you can use $record->toArray() to get back a Monolog 1/2 style record array. This will contain the enum values instead of enum cases in the level and level_name keys to be more backwards compatible and use simpler data types.

We need to change types for Chrisguitarguy\RequestId\Monolog\RequestIdProcessor::__invoke to support Monolog 3 and previous versions. Because this bundle support PHP 7.4 we cannot use Union types.
My idea is to remove types and check variable's type $record in method.

I will prepare PR soon (to end of this week).

Should be fairly easy to do as the only thing we rely on is a UUID factory and Uuid::__toString.