chrisandre / tkintertable Goto Github PK

What steps will reproduce the problem?
1. create a default TableCanvas
2. press left arrow key until the current cell moves to the first column of any 
rows different from the first row
3. the selection disappear and could not move to the previous role, exception 
of IndexError is throwed

What version of the product are you using? On what operating system?
Latest version on Linux

Suggestions:

Please modify in handle_arrow_keys():

        elif event.keysym == 'Left':
            if self.currentcol == 0:
                if self.currentrow == 0:
                    return
                else:
                    self.currentcol = self.cols-1
                    self.currentrow = self.currentrow - 1
            else:
                self.currentcol  = self.currentcol -1

There is no support for Python 3, even if

pip install tkintertable

only puts out some warnings.
Code crashes for some

print '...'

statements.

first thanks for this great program 
second i am beginner in python and tkinter i faced with this bugs when trying 
to use the python 3 version of tkintertable and this my try 
to fix them so if there is something wrong i am sorry for any misunderstanding  
i use python 3.4.2 , windows xp  
--------------------------------------------------
1-
in the first after loading the table in it's parent frame i got this error in 
File Tables.py line 2143, in checkOSType

    ostyp=string.lower(os.environ[var])
AttributeError: 'module' object has no attribute 'lower'

i fix it by make change from using srting to str

in line 2143 in Tables.py change the line from:

ostyp=string.lower(os.environ[var])

to:

ostyp=str.lower(os.environ[var])

-----------------------------------------
2- 

the reason of this bug is moving the mouse over an empty place on the table it 
raise TypeError in the handle_motion function in Table.py module in line 1032 

if 0 <= row < int(self.rows) and 0 <= col < self.cols:

this happen if i move the mouse over an empty place that have no 
columns in it and if we use python 2 it did't give me this error the reason
for that is in python 2 when we compare two value one of them is None like 
1 < None it will give us the result of comparison False but in python 3 it
raise a TypeError so if i move the mouse over an empty place on the table
it make one of the event coordinate None so it make comparison with None type 
and integer type 
to fix this error i catch it through try except statement like this:

try:
    if 0 <= row < int(self.rows) and 0 <= col < self.cols:
        self.drawTooltip(row, col)
except TypeError:
    return 
return 
-----------------------------------------------------------

3-

this bug raise if i specified column label bigger than 12 characters

Traceback (most recent call last):
  File "F:\4\test\python\3\test.py", line 28, in <module>
    set_income_table()
  File "F:\4\test\python\3\test.py", line 24, in set_income_table
    table.createTableFrame()
  File "F:\4\test\python\3\tkintertable\Tables.py", line 218, in createTableFrame
    self.redrawTable(callback=callback)
  File "F:\4\test\python\3\tkintertable\Tables.py", line 330, in redrawTable
    self.redrawVisible(event, callback)
  File "F:\4\test\python\3\tkintertable\Tables.py", line 316, in redrawVisible
    self.tablecolheader.redraw()
  File "F:\4\test\python\3\tkintertable\Tables.py", line 2222, in redraw
    collabel=collabel[0:int(w)/12]+'.'
TypeError: slice indices must be integers or None or have an __index__ method

in Tables.py file in line 2222 in the redraw function if the column label 
is bigger than 12 character it will give me the former error the reason for 
that is the division section in this line 

collable=collabel[0:int(w)/12]+'.'

because the result of the division int(w)/12 will be float number in python 3 
and this raise the former error so the fix to this error to change the division 
to floor division or integer 
division so the line will be like this:

collable=collable[0:int(w)//12]+'.'

---------------------------------------------------------------

4-

this error raise if i left click any empty space to the right of the table but 
it will not appear if this empty place was down the last row it only appear if 
i click the empty space to the right of table rows in the none columns space it 
will raise type error like the one appear in the one i mention in number 2 and 
appear like this

Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Python34\lib\tkinter\__init__.py", line 1533, in __call__
    return self.func(*args)
  File "F:\4\test\python\3\tkintertable\Tables.py", line 863, in handle_left_click
    if 0 <= rowclicked < self.rows and 0 <= colclicked < self.cols:
TypeError: unorderable types: int() <= NoneType()

and the reason for this bug is the way python 3 handle the comparisons if i 
compare None with integer it will not return with false but raise a TypeError 
and i fixed it by use try catch statement with the if block in code from line 
862 to 871 like this:

i change it from:

        if 0 <= rowclicked < self.rows and 0 <= colclicked < self.cols:
            self.setSelectedRow(rowclicked)
            self.setSelectedCol(colclicked)
            self.drawSelectedRect(self.currentrow, self.currentcol)
            self.drawSelectedRow()
            self.tablerowheader.drawSelectedRows(rowclicked)
            coltype = self.model.getColumnType(colclicked)
            if coltype == 'text' or coltype == 'number':
                self.drawCellEntry(rowclicked, colclicked)
        return

to be like this:

        try:
            if 0 <= rowclicked < self.rows and 0 <= colclicked < self.cols:
                self.setSelectedRow(rowclicked)
                self.setSelectedCol(colclicked)
                self.drawSelectedRect(self.currentrow, self.currentcol)
                self.drawSelectedRow()
                self.tablerowheader.drawSelectedRows(rowclicked)
                coltype = self.model.getColumnType(colclicked)
                if coltype == 'text' or coltype == 'number':
                    self.drawCellEntry(rowclicked, colclicked)
        except TypeError:
            return

        return

------------------------------------------------------------------------------
5-

this bug appear if i click of Preferences menu item to show the preferences 
window it will not show
the window and raise _tkinter.TclError like this:

Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Python34\lib\tkinter\__init__.py", line 1533, in __call__
    return self.func(*args)
  File "F:\4\test\python\3\tkintertable\Tables.py", line 1802, in showtablePrefs
    self.prefswindow.geometry('+%s+%s' %(x+w/2,y+h/2))
  File "C:\Python34\lib\tkinter\__init__.py", line 1669, in wm_geometry
    return self.tk.call('wm', 'geometry', self._w, newGeometry)
_tkinter.TclError: bad geometry specifier "+418.0+301.5"

and this one also like bug number three the reason for it is the way python 3 
handle division so in showtablPrefs in Tables.py module in line 1802 

self.prefswindow.geometry('+%s+%s' %(x+w/2,y+h/2))

to fix it i change the divison from float divison to floor or integer division 
like this

self.prefswindow.geometry('+%s+%s' %(x+w//2,y+h//2))
-----------------------------------------------------------------------
6-

this bug present if i call the File-->New context menu it will raise this 
NameError 

Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Python34\lib\tkinter\__init__.py", line 1533, in __call__
    return self.func(*args)
  File "F:\4\test\python\3\tkintertable\Tables.py", line 2086, in new
    parent=self.parentframe)
  File "F:\4\test\python\3\tkintertable\Dialogs.py", line 97, in __init__
    if labels != None and types != NoneType:
NameError: name 'NoneType' is not defined


the reason for it that in python 2 you use the Tkinter.NoneType that present in 
the Tkinter library but and that already inhered from the type library but this 
NoneType no longer exist in python 3 and also in tkinter so i fix it by calling 
type(None) instead of explicit NoneType so i change line 97 in Dialogs.py 
module in the __init__ method from this:

if labels != None and types != NoneType

into this:

if labels != None and types != type(None)

i got this from dive into python 3 book appendix a. Porting Code to Python 3 
with 2to3

---------------------------------------------------------

and i upload the two files Tables.py and Dialogs.py after fixing this error on 
them may be if you like to add them to the program for any future release and 
thanks again for this great tool...

Karim Reefat

Hi,

I am trying to use your module to import some stored data and programmatically 
add rows as new information comes in.  I am having trouble specifying the order 
of the columns as they are created.  

I have modified your createData() function as:

def createData():

    data = {}
    serials = [ '3456', '2343', '2345' ]
    colnames = [ 'Serial', 'IP', 'Name' ]

    for sn in serials:
        data[sn] = {}

    ips = ['172.26.2.1', '172.26.2.2', '172.26.2.3']
    names = ['Test1', 'Test2', 'Test3']

    i=0
    for sn in serials:
        data[sn][colnames[0]] = serials[i]
        data[sn][colnames[1]] = ips[i]
        data[sn][colnames[2]] = names[i]
        i+=1

    return data

The problem I am finding is that the IP column is the first column, rather than 
the serial number.  How can I switch the order of these columns at the start of 
the program?

Thanks,

Patrick

What steps will reproduce the problem?
1. use tkintertable on Windows
2. try to export as csv
3. open the csv file in excel

What is the expected output? What do you see instead?

Expected output:
A csv file without empty lines interspersed

What happens:
An empty line follows every intended line due to an extra carriage return.

What version of the product are you using? On what operating system?
Windows 7, tkintertable v 1.1.2


Please provide any additional information below.
You should change line 147 in Tables_IO.py from 
>writer = csv.writer(file(filename, "w"), delimiter=sep)
to
>writer = csv.writer(file(filename, "wb"), delimiter=sep)
Opening the file in text mode on Windows inserts an extra carriage return.  See 
here:
http://stackoverflow.com/questions/3348460/python-getting-rid-of-extra-line

Code responsible for opening files:

filename=tkFileDialog.askopenfilename(defaultextension='.tbleprj"',
                                                      initialdir=os.getcwd(),
                                                      filetypes=[("Pickle file","*.tbleprj"),
                                                                 ("All files","*.*")],
                                                      parent=self.tablesapp_win)


despite file default extension should be .tblprj

What steps will reproduce the problem?
1. Create a table with records
2. Have a window that's larger than the list of records so there is open area
3. Double click the area.
4. Exception occurs: list index of of range. name=self.reclist[rowindex]

What is the expected output? What do you see instead?

Nothing should happen when you double click somewhere without a row/column.

What steps will reproduce the problem?
1. Create a normal TableCanvas with rows and height set to larger values (say 
30*20)
2. Click window maximize button
3. The contents of TableCanvas outside the initial window range are not 
properly displayed in the maximized window.

What is the expected output? What do you see instead?
All the contents should be properly displayed.

What version of the product are you using? On what operating system?
Latest. Linux

Please provide any additional information below.
Suggestions: in TableCanvas.createTableFrame() add:

        # Fix the bug of not being properly redrawn during maximizing
        # the default behavior only bind <Configure> event for
        # the parent frame BUT NOT for the inherited Canvas class.
        self.bind('<Configure>', lambda event: self.redrawTable())

What steps will reproduce the problem?
1. ran testing.py that came with the package.
2. deleted all rows except the last one from the table. Then removed the last 
one.
3. Last one doesnt get deleted. It remain in the table. Once you add new row it 
gets cleared from the view.

What is the expected output? What do you see instead?
the last entry should be delete. last entry doesnt get deleted.


What version of the product are you using? On what operating system?
tkintertable (1.1.2) ( windows 7 64 bit


Please provide any additional information below.

What steps will reproduce the problem?

Let's say you have a TableModel called tableModel with 10 rows:
-call tableModel.deleteRows(0,10)
or
- select all the rows with GUI and delete them through the popup dialog 
clicking on "Delete Row(s)"

What is the expected output? What do you see instead?

I would expect the rows not to be visible anymore, but they are still visible, 
even if unresponsive to user action, like clicking on them.

What version of the product are you using? On what operating system?

tkintertable-1.1.2, Linux Mint 15 (Ubuntu 13.04)

Please provide any additional information below.

If new rows are inserted, the content of the table is displayed correctly.
The problem appears only if you delete all the rows, not just one or a subset 
of the total rows.

Always prints "loading prefs from [filename]" at startup. This should be 
suppressed by default.

What steps will reproduce the problem?
1. Create a TableCanvas with default settings
2. Double click in area beyond the rows or columns
3. IndexError is throwed

What version of the product are you using? On what operating system?
Latest version on Linux

Suggestion: Please modify code in handle_double_click as follows:

        row = self.get_row_clicked(event)
        col = self.get_col_clicked(event)
        if row not in range(0, self.rows) or col not in range(0, self.cols):
            return

What steps will reproduce the problem?
1. Create a table
2. Add data with a new line
3. Data trails off the bottom edge.

What is the expected output? What do you see instead?

I expected row height to be increased when specific rows need it. That is, rows 
with three lines of data in an entry will be three times as tall, while the 
remaining rows will still be only one line tall.

Sorry if this isn't the right venue, I couldn't find a better way to e-mail you 
guys.

What steps will reproduce the problem?
1. go to usage
2. copy and paste imports
3. traceback says no pmw

What is the expected output? What do you see instead?
is it supposed to depend on pmw? I didn't see that in the documentation.

What version of the product are you using? On what operating system?
1.1.2

Please provide any additional information below.
I used pip install tkintertable

What steps will reproduce the problem?
1. Just use the first 2 import statements
2.
3.

What is the expected output? What do you see instead?
Expect:   Goodness
Actual:
Traceback (most recent call last):
  File "C:\Python32\tbvpython\tkintertable_test1.py", line 5, in <module>
    from tkintertable.Tables import TableCanvas
  File "C:\Python32\lib\site-packages\tkintertable-1.1.2-py3.2-win32.egg\tkintertable\Tables.py", line 560
    print 'found in',row,col
                   ^
SyntaxError: invalid syntax


What version of the product are you using? On what operating system?  1.1.2 
against Python32 on windows XP machine


Please provide any additional information below.
tkinter works with no problem