Git Product home page Git Product logo

babel-plugin-transform-async-to-bluebird's Introduction

Hi there ๐Ÿ‘‹

babel-plugin-transform-async-to-bluebird's People

Contributors

chpio avatar karimsa avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

babel-plugin-transform-async-to-bluebird's Issues

Class methods get wrapped twice

I've experienced a strange bug while trying to use this plugin. I believe it is caused by the wrapping of async class methods twice (seems to stop the coroutine from running).

Here is a sample code snippet that reproduces the bug:

class Test {
  async go () {
    console.log('start:go')
    await Promise.resolve('test')
    console.log('end:go')
  }
}

const runGo = () => {
  return (new Test()).go()
}

;(async () => {
  console.log('start:all')
  await runGo()
  console.log('end:all')
})()

If you transpile this using the bluebird preset (which relies on this plugin) and the transform-es2015-modules-commonjs plugin, the resultant code is this:

'use strict';

var _bluebird = require('bluebird');

class Test {
  *go() {
    return (0, _bluebird.coroutine)(function* () {
      console.log('start:go');
      yield (0, _bluebird.resolve)((0, _bluebird.resolve)('test'));
      console.log('end:go');
    })();
  }
}

const runGo = () => {
  return new Test().go();
};

(0, _bluebird.coroutine)(function* () {
  console.log('start:all');
  yield (0, _bluebird.resolve)(runGo());
  console.log('end:all');
})();

Running this showing the promise never running:

start:all
end:all

If I simply remove the * from the go class method in the transpiled output (and therefore just undo its generatorness - and let it return the coroutine generator instead), this issue goes away and the result is:

start:all
start:go
end:go
end:all

babel 7 support

Are there any plans to release a beta version of this plugin that works with babel 7?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.