Git Product home page Git Product logo

testmod3's Issues

[1.16.x] CapabilityContainerListener system doesn't work properly for player inventory

@Tavi007 found in this thread that the CapabilityContainerListener system doesn't properly update items in the player inventory until they're moved.

This seems to be caused by Forge patching Container#detectAndSendChanges to only call IContainerListener#sendSlotContents if a slot's Item, count or share tag has changed; which often won't be the case for capability-only updates.

This change was actually introduced in August 2017 for 1.12.2 (in MinecraftForge/MinecraftForge#4252), six months after I created my system. I thought it was working more recently than that, but I must not have tested it properly.

I need to see if there's any way around this.

DummyRecipe, minus the warnings

The following, while a bit dirty, gets rid of the warnings about resources from the wrong mod:

public DummyRecipe( final ResourceLocation location )
{
	try {
		@SuppressWarnings( "rawtypes" )
		final Class< IForgeRegistryEntry.Impl > cls = IForgeRegistryEntry.Impl.class;
		final Field fld = cls.getDeclaredField( "registryName" );
		fld.setAccessible( true );
		fld.set( this , location );
	} catch ( NoSuchFieldException | SecurityException | IllegalArgumentException | IllegalAccessException e ) {
		throw new RuntimeException( "Apparently, LexManos doesn't approve." , e );
	}
}

[1.17.1] Update Testing Checklist

Every class/feature of the mod should be tested in 1.17.1 to ensure that it's working. This may be done over a very long period of time.

  • Advancement

    • FluidContainerItemPredicate
    • ModCriterion
  • Biome

    • Data Gen
      • TestMod3BiomeReport
    • ModBiomes
  • Block

    • Client
      • ClientOnlyBlockMethods
    • Coloured Rotatable
      • ColoredMultiRotatableBlock
      • ColoredRotatableBlock
    • Dispense Behaviour
      • ModDispenseBehaviors
    • Data Gen
      • TestMod3BlockStateProvider
      • TestMod3BlockTagsProvider
    • Material
      • ModMaterials
    • Fluid Tank
      • FluidTankContentsMessage
    • Survival Command Block
      • SurvivalCommandBlockEditScreen
      • SaveSurvivalCommandBlockMessage
      • SurvivalCommandBlock (logic)
      • SurvivalCommandBlockEntity
      • SurvivalCommandBlock (block)
    • Item Handler
      • ItemHandlerBlockEntity
      • LockableItemHandlerBlockEntity
      • LootItemHandlerBlockEntity
      • ModChestBlockEntity
      • ModChestBlock
    • Pipe
      • BasePipeBlock
      • BasicPipeBlock
      • FluidPipeBlock
    • Potion Effect
      • PotionEffectBlockEntity
    • Slab
      • ColouredSlabBlock
      • TestMod3SlabBlock
    • Variant Group
      • BlockVariantGroup
      • IBlockVariantGroup
    • BaseEntityBlock
    • ClientPlayerRightClickBlock
    • ClientPlayerRotationBlock
    • InvisibleBlock
    • ItemCollisionTestBlock
    • ItemDebuggerBlock
    • LargeCollisionTestBlock
    • PlaneBlock
    • PotionEffectBlock
    • RightClickTestBlock
    • RotatableLampBlock
    • SmallCollisionTestBlock
    • StaticPressurePlateBlock
    • TestMod3SaplingBlock
    • VariantsBlock
    • WaterGrassBlock
    • ModBlockEntities
    • ModBlocks
  • Capability

    • Chunk Energy
      • IChunkEnergy
      • ChunkEnergy
      • ChunkEnergyCapability
      • GuiChunkEnergyHUD
      • UpdateChunkEnergyValueMessage
      • ChunkEnergyGetterItem
      • ChunkEnergySetterItem
    • Hidden Block
      • IHiddenBlockRevealer
      • HiddenBlockRevealer
      • HiddenBlockRevealerCapability
      • HiddenBlockRevealerContainerListener
      • HiddenBlockManager
      • RevealHiddenBlocksItemPropertyFunction
      • HiddenBlockRevealerFunctions
      • UpdateMenuHiddenBlockRevealerMessage
      • HiddenBlockRevealerItem
      • HiddenBlockEntity
      • HiddenBlock
    • Fluid Handler
      • FluidHandlerCapability
      • FluidTankContainerListener
      • FluidHandlerFunctions
      • UpdateMenuFluidTankMessage
      • ModBucketItem
      • BaseFluidTankBlockEntity
      • FluidTankBlockEntity
      • RestrictedFluidTankBlockEntity
      • FluidTankSnapshot
      • UniversalBucketFluidHandler
      • ItemFluidTank
      • FluidTankBlock
      • FluidTankItem
      • RestrictedFluidTankBlock
    • Last Use Time
      • ILastUseTime
      • LastUseTime
      • LastUseTimeCapability
      • LastUseTimeContainerListener
      • TicksSinceLastUseItemPropertyFunction
      • LastUseTimeFunctions
      • UpdateMenuLastUseTimeMessage
      • LastUseTimeModelItem
      • SlingshotItem
    • Lock
      • ILock
      • BaseContainerBlockEntityWrapper
      • Lock
      • LockCapability
      • LockScreen
      • SetLockCodeMessage
      • KeyItem
    • Max Health
      • IMaxHealth
      • MaxHealth
      • MaxHealthCapability
      • AddMaxHealthCommand
      • GetMaxHealthCommand
      • MaxHealthCommand
      • SetMaxHealthCommand
      • MaxHealthGetterItem
      • MaxHealthSetterItem
      • MaxHealthGetterBlock
      • MaxHealthSetterBlock
    • Pig Spawner
      • IPigSpawner
      • IPigSpawnerFinite
      • IPigSpawnerInteractable
      • BasePigSpawner
      • FinitePigSpawner
      • FinitePigSpawnerContainerListener
      • InfinitePigSpawner
      • PigSpawnerCapability
      • PigSpawnerFunctions
      • UpdateMenuPigSpawnerFiniteMessage
      • PigSpawnerItem
      • PigSpawnerRefillerBlock
    • Container Listener
      • CapabilityContainerListener
      • CapabilityContainerListenerManager
      • CapabilityMenuUpdateMessageUtils
      • UpdateMenuCapabilityMessage
    • Provider
      • SerializableCapabilityProvider
      • SimpleCapabilityProvider
    • ModCapabilities
  • Client

    • Event
      • ClientEventHandler
      • ClientPlayerNetworkEventHandler
      • HUDEventHandler
    • GUI
      • ModChestScreen
      • ClientScreenManager
      • GuiIDs
      • OpenClientScreenMessage
    • Init
      • ModItemModelProperties
      • ModKeyMappings
      • ModRenderLayerSetup
      • ModScreenFactories
    • Key Mapping
      • KeyMappingHandler
    • Model
      • ModColourManager
    • Entity Renderer
      • ModRenderers
      • RenderModArrow
    • Util
      • ClientOnlyMethods
      • ClientUtil
  • Codec

    • VanillaCodecs
  • Command

    • ModArgumentTypes
    • ModCommands
    • AxisArgument
    • RotateVectorCommand
    • RunTestsCommand
    • TestMod3Command
  • Config

    • TestMod3Config
  • Crafting

    • Data Gen
      • Ingredient
        • ConditionalIngredientBuilder
        • MobSpawnerIngredientBuilder
      • Recipe
        • DelegateFinishedRecipe
        • EnhancedShapedRecipeBuilder
        • EnhancedShapelessRecipeBuilder
        • ShapedArmourUpgradeRecipeBuilder
        • ShapelessCuttingRecipeBuilder
        • ShapelessFluidContainerRecipeBuilder
        • SimpleFinishedRecipe
        • TestMod3RecipeProvider
    • Ingredient
      • ConditionalIngredientSerializer
      • FluidContainerIngredient
      • IngredientNever
      • MobSpawnerIngredientSerializer
      • TestMod3NBTIngredient
    • Recipe
      • RecipeUtil
      • ShapedArmourUpgradeRecipe
      • ShapelessCuttingRecipe
      • ShapelessFluidContainerRecipe
    • ModCrafting
  • Data Gen

    • ModDataProviders
  • Data Fixer

    • ModDataFixers
  • Entity

    • ModEntities
    • BlockDetectionArrow
    • ModArrow
    • PlayerAvoidingCreeper
  • Event

    • BlockEventHandler
    • ItemCombinationHandler
    • PlayerEventHandler
  • Fluid

    • FluidGroup
    • StandardFluidGroup
    • PortalDisplacementFluid
    • StaticFluid
    • BlockFluidNoFlow
    • BlockFluidPortalDisplacement
    • ModFluids
  • Item

    • Data Gen
      • TestMod3ItemModelProvider
      • TestMod3ItemTagsProvider
    • Variant Group
      • IItemVariantGroup
      • ItemVariantGroup
    • BlockDebuggerItem
    • BlockDestroyerItem
    • ClearerItem
    • ContinuousBowItem
    • CuttingAxeItem
    • DimensionReplacementItem
    • EntityCheckerItem
    • EntityInteractionTestItem
    • EntityKillerItem
    • EntityTestItem
    • HarvestSwordItem
    • HeavyItem
    • HeightTesterItem
    • LootTableTestItem
    • ModArmourMaterial
    • ModArrowItem
    • ModBowItem
    • ModSpawnEggItem
    • ModTiers
    • PotionEffectArmourItem
    • ReplacementArmourItem
    • RespawnerItem
    • RestrictedArmourItem
    • RitualCheckerItem
    • ScriptsItem
    • SlowSwordItem
    • SnowballLauncherItem
    • SoundEffectItem
    • SubscriptsItem
    • SuperscriptsItem
    • SwapTestItem
    • UnicodeTooltipsItem
    • VariantsItem
    • ModItems
  • Inventory

    • Menu
      • ModMenuTypes
      • ModChestMenu
      • IMenuCallbacks
    • Item Handler
      • BlockEntityLootItemHandler
      • LootItemHandler
  • Language/Localisation

    • Data Gen
      • TestMod3LanguageProvider
    • TestMod3Lang
  • Loot Table

    • Data Gen
      • TestMod3BlockLootTables
      • TestMod3EntityLootTables
      • TestMod3GenericLootTables
      • TestMod3LootTableProvider
      • TestMod3LootModifierProvider
    • Condition
      • IsChestLoot
      • MatchBlockTag
      • ModLootConditionTypes
    • Function
      • SetFluidTankContents
      • ModLootFunctionTypes
    • Modifier
      • ModLootModifierSerializers
      • BlockEntityNBTLootModifier
      • ItemLootModifier
      • LootTableLootModifier
    • FluidStackItem
    • ModLootTables
  • Mod Compatibility

    • The One Probe
      • BaseProbeInfoProvider
      • EnumPropertyProbeInfoProvider
      • MultiRotatableProbeInfoProvider
      • RestrictedFluidTankEnabledFacingsProbeInfoProvider
      • RotatableProbeInfoProvider
      • TheOneProbeCompat
      • VerticalRotatableProbeInfoProvider
    • Waila/Hwyla
      • EnumPropertyHUDHandler
      • ItemTooltipModNameRemover
      • MultiRotatableHUDHandler
      • RestrictedFluidTankEnabledFacingsHUDHandler
      • RotatableHUDHandler
      • VerticalRotatableHUDHandler
      • WailaCompat
  • Network

    • ModNetwork
  • Potion

    • ModEffects
    • ModPotions
    • TestMod3MobEffect
  • Registry

    • ModTestRegistryEntries
    • IVariantGroup
    • TestRegistryEntry
  • Remapping

    • Remapper
  • Sound Event

    • ModSoundEvents
  • Tag

    • ModTags
  • Testing

    • EndNBTTests
    • HttpClientTests
    • Test
    • Tests
  • Tweak

    • SnowBuildup
  • Utility

    • BlockDumper
    • CapabilityNotPresentException
    • Constants
    • DebugUtil
    • EnumFaceRotation
    • InjectionUtil
    • InventoryUtils
    • LogUtil
    • ModFluidUtil
    • ModJsonUtil
    • NameHolder
    • NetworkUtil
    • RegistryUtil
    • Scheduler
    • StringUtils
    • SwordUpgrades
    • VectorUtils
  • World Gen

    • Decorator
      • InChunksDivisibleBy16
      • ModConfiguredDecorators
      • ModFeatureDecorators
    • Feature
      • BannerFeature
      • BannerFeatureConfig
      • ModConfiguredFeatures
      • ModFeatures
    • Surface Builder
      • LoggingSurfaceBuilder
      • ModConfiguredSurfaceBuilders
      • ModSurfaceBuilders
    • ModLevelGen
  • TestMod3

  • TestMod3CreativeModeTab

Custom armor

Hey can you give me a link to where i can find the coding for rendering the armor model, for some reason its searching for _layer_1 but is not putting the name of my armor, im really at a loss.

help me w/ item variants

Potion icon not working

The custom potion icon code added in 2036dae renders just over 1 square pixel of the icon (from the top-left corner) stretched to 18x18 pixels.

2016-07-13_06 24 44
2016-07-13_06 24 54

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.