Cause

App randomly crashed because of error while decoding MovieDetail model

Solution

• Need to fix Movie Detail model
• #43 (Continue Work on this issue later)

Because Cell is reused, cell has data of previous useage
Text & CosmosView data changed immediately, but UIImageView has unmatching image (which is poster image of previous cell useage)

So this happens:

1. Caching feature is only supported to Image. Need to support API Caching
   Proceed after API refactoring (Not easy to develop API Caching because API code is mostly static function)

2. Need to invalidation of cache by time

• Add API Caching
• Invalidating old cache data by time

Even if there's no synopsis text, there's space for label. Need to hide label when text is empty and remove unintended margin between title and running time

Describe

When new category is selected from UIMenu, Chart Table View should be reloaded immediately. But It doesn't reload until manual refresh

To Reproduce

1. Go to Chart Tab
2. Select different category from UIMenu

Expected behavior

Chart Table should reload immediately when UIMenu selected

Screenshots

Device: iPhone 12 mini
OS: iOS 16.1

In ChartView, there's 3 category -> Popular Top Rated Now Playing

But refresh control present Popular list no matter which category app is presenting

[Situation]
In Chart List view, list contents are appending too fast and sometimes cause crash

Describe

In Chart View:

• List should appended when scroll reach to bottom

These two function is not working

To Reproduce

1. Go to 'Chart' Tab
2. Scroll to bottom

Expected behavior

• When list scrolled to bottom: new contents are appended to list

Additional context

This issue created after fixing issue #58

Adding SwiftLint for better code style

• Add SwiftLint to Pod
• Edit .yml file

1. Force decoding

Need to fix forced unwrapping when decoding API response:

// func requestData(contentId: Int)
let response = try! JSONDecoder().decode(MovieDetail.self, from: data)

There's too many try! code in project. Need to fix

2. Model seperation

This project is now using API response model for view.
Need to use different model for view and separate dependency between View <-> API

Abstract

For all UIViewController in this project, there are common code like this:

    override func viewDidLoad() {
        super.viewDidLoad()
        
        setUpView()
        setUpLayout()
        bindData()

        // Additional codes
    }

Creating protocol to make those patterns as convention for this project.

Set convention and template for Issue PR (Title & description)
Title convention will be written in description template as comment.

• Issue template
• PR template

Describe

Background color of cells at CreditView is wrong

To Reproduce

• Go to Credit Tab
• Always happens

Expected behavior

Background color should be dark color as usual

Screenshots

Device: iPhone 12 mini
OS: iOS 16.1

Additional context

• This issue produces after PR #56
• Probably replacing UITableViewCell to CreditTableView cause this issue

• Create Page Design
• Complete page

From DiscoverViewController...
header view generated as UICollectionReusableView missing when using RxCocoa instead of UICollectionView DataSource

Because datasource is not used, this function is not working:

func collectionView(_ collectionView: UICollectionView,  viewForSupplementaryElementOfKind kind: String, 
                            at indexPath: IndexPath) -> UICollectionReusableView

Describe

• Animation is flickering and scroll seems not smooth

To Reproduce

Steps to reproduce the behavior:

1. Go to Chart
2. Swipe down to activate refresh control
3. See error

Expected behavior

Refresh control need to be animate successfully

Additional context

Issue created & developed after fixing #65

• Add Image Caching
• Add API response Caching

Situation

Cell identifiers are now managed as constant property.
There's room for improvement using Protocol or Generics

Reference

• Nicer reuse identifiers with protocols in Swift
• iOS Cell Registration & Reusing with Swift Protocol Extensions and Generics - gist
• iOS Cell Registration & Reusing with Swift Protocol Extensions and Generics - medium

Description

Current Chart list is not changing scroll location

Benefit

Better User Experience. (User need to see list from first when they change category)

Additional context

Current version has diffrent action by number of rows

• numberOfRows <= 20 Scroll location not changes
• numberOfRows > 20 Scrolled to first row but not top (Navigation title is not presented as large title)

Cannot go back from DetailView using Navigation Swipe gesture

Required

• DetailView Add trailer collection view
• DetailView Add cast collection view
• ChartView DiscoverView Infinite scroll
• ChartView DiscoverView scroll up to refresh
• CreditView Dev info, API, Design reference

Optional

• change App Name: Filmboard
• README.md Change App Icon into Rounded corner version
• Use Alamofire

Describe

Contents of REAME example images contains UI issues that already fixed

Expected behavior

REAME Example images should be replaced with screenshots taken after ver 0.1.0

From DiscoverViewController & ChartViewController, CollectionView & TableView cells randomly have other cell's image or image keep changing while reusing.

Need to check 2 possibilities:

1. Cell reusable related issue
2. Downloading and inserting image is run concurrently

Things to write

• Installation guide
• Sample Screenshot
• Used APIs
• Used Pods
• Architecture (Continue after all refactoring works)

Same Issue:

• #20

Try solutions from answer of Stackoverflow link: UITableViewCell image from url is wrong at first load

1. Use URLSession
2. Use Kingfisher

All SubViews of DiscoverCollectionView disappear when imageView.image set from collectionView(_:cellForItemAt:)

Constant.swift

import Foundation

struct Colors {
    static let background = "BgColor"
    static let light_background = "LightBgColor"
    static let placeholder = "PlaceholderTextColor"
}

struct identifiers {
    static let discover_collection_cell = "DiscoverCollectionCell"
    static let discover_collection_header = "DiscoverCollectionHeader"
    
    static let chart_table_cell = "ChartTableCell"
    static let chart_table_header = "ChartTableHeader"
    
    static let credit_table_cell = "CreditTableCell"
    
    static let detail_trailer_collection_Cell = "DetailTrailerCollectionCell"
    static let detail_cast_collection_Cell = "DetailCastCollectionCell"
}


let genreCode = [
    28 : "Action",
    12 : "Adventure",
    16 : "Animation",
    35 : "Comedy",
    80 : "Crime",
    99 : "Documentary",
    18 : "Drama",
    10751 : "Family",
    14 : "Fantasy",
    36 : "History",
    27 : "Horror",
    10402 : "Music",
    9648 : "Mystery",
    10749 : "Romance",
    878 : "Science Fiction",
    10770 : "TV Movie",
    53 : "Thriller",
    10752 : "War",
    37 : "Western"
]

• refactor color constant using UIColor extension
• Make cell identifiers as static variable of class
• Move genre code to Domain or Model part

There's UIMenu Item changing category of chart(Update tableview content)
But It's not working:

UIAction(title: "Popular", image: UIImage(systemName: "flame.fill"), handler: { _ in self.viewModel.requestData(category: .Popular) }),
UIAction(title: "Top Rated", image: UIImage(systemName: "star.fill"), handler: { _ in self.viewModel.requestData(category: .TopRated) }),
UIAction(title: "Now Playing", image: UIImage(systemName: "theatermasks.fill"), handler: { _ in self.viewModel.requestData(category: .NowPlaying) })

File Structure of this project is kind of mess. Need rework.

Reference:

• Template iOS App using Clean Architecture and MVVM
• Clean Architecture and MVVM on iOS