The string_splitter's discuss from chocolateboy

string_splitter's Issues

remove_empty removes non-empty delimiters

StringSplitter	1.1.1
Ruby	ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
OS	Linux (Arch)

The remove_empty option removes empty fields, as expected, but it also appears to be removing non-empty delimiters.

Test

ss = StringSplitter.new(remove_empty: true, include_captures: true)
ss.split("::", ":")

Expected

[":", ":"]

Actual

[]

Trailing empty fields

StringSplitter#split (and #rsplit) produces a trailing empty field if the separator is empty e.g.:

ss.split("foo", "")   # => ["f", "o", "o", ""]
ss.split("foo", //)   # => ["f", "o", "o", ""]
ss.split("foo", /()/) # => ["f", "", "o", "", "o", "", ""]

This is because String#split includes them in its results:

"foo".split("", -1)   # => ["f", "o", "o", ""]
"foo".split(//, -1)   # => ["f", "o", "o", ""]
"foo".split(/()/, -1) # => ["f", "", "o", "", "o", "", ""]

We can omit them by passing a non-negative limit, but this produces the wrong results in cases where there are trailing non-empty delimiters i.e.:

# right
"foo:bar:baz:".split(":", -1)    # => ["foo", "bar", "baz", ""]
"foo:bar:baz::".split(/:/, -1)   # => ["foo", "bar", "baz", "", ""]
"foo:bar:baz::".split(/(:)/, -1) # => ["foo", ":", "bar", ":", "baz", ":", "", ":", ""]

# wrong
"foo:bar:baz:".split(":", 0)    # => ["foo", "bar", "baz"]
"foo:bar:baz::".split(":", 0)   # => ["foo", "bar", "baz"]
"foo:bar:baz::".split(/:/, 0)   # => ["foo", "bar", "baz"]
"foo:bar:baz::".split(/(:)/, 0) # => ["foo", ":", "bar", ":", "baz", ":", "", ":"]

Recommend Projects