Git Product home page Git Product logo

Comments (6)

Chlumsky avatar Chlumsky commented on June 25, 2024

As you can see, the logic before project needs to configure stuff for the vcpkg toolchain so this is intentional. Using vcpkg is not hardcoded, you can disable it with MSDFGEN_USE_VCPKG.

from msdfgen.

SpaceIm avatar SpaceIm commented on June 25, 2024

Even if there is an option, this logic leads to an illformed CMakeLists, where options and some logic unrelated to vcpkg are defined before projects just because of this vcpkg intrusion (actually I realize that you could not even move other options after project() because you have vcpkg logic based on these options which has be done before project()).

from msdfgen.

SpaceIm avatar SpaceIm commented on June 25, 2024

Could you at least move MSDFGEN_DYNAMIC_RUNTIME and BUILD_SHARED_LIBS logic after project() please?

I mean this part:

if(MSDFGEN_DYNAMIC_RUNTIME)
    set(MSDFGEN_MSVC_RUNTIME "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
else()
    set(MSDFGEN_MSVC_RUNTIME "MultiThreaded$<$<CONFIG:Debug>:Debug>")
endif()

if(BUILD_SHARED_LIBS)
    set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
endif()

from msdfgen.

Chlumsky avatar Chlumsky commented on June 25, 2024

But why?

from msdfgen.

SpaceIm avatar SpaceIm commented on June 25, 2024

Because it defeats conan toolchain.

from msdfgen.

Chlumsky avatar Chlumsky commented on June 25, 2024

Sorry, I kind of forgot about this but changed it now.

from msdfgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.