relational_row_to_json panics with a float row about chiselstrike HOT 7 CLOSED

Trying to print the Row before we get to that point says this:

i : 5 ("height", Float) => AnyColumn { kind: Sqlite(SqliteColumn { name: height, ordinal: 5, type_info: SqliteTypeInfo(Null) }), type_info: AnyTypeInfo(Sqlite(SqliteTypeInfo(Null))) }

typeinfo being null is suspicious

from chiselstrike.

@espindola there is a FIXME from you in that code:

        // FIXME: consider result_column.type_info().is_null() too

So maybe you have an idea.

from chiselstrike.

This seems to work when I insert the value "5.23" but crash when I insert the value "5.0"

from chiselstrike.

I am very certain this is just a stupid sqlx bug.
I will see if I can spend some time on a small reproducer, but ultimately we'll parse floats by hand.

from chiselstrike.

A reproducer would be nice. Can you write a .lit file that crashes? I can reduce from there if you want.

from chiselstrike.

cargo test fails and panics with this commit : a0b5d47

The PR that contains that commit doesn't fail, because it moves parsing of floats to a manual parse, but if you cherry pick that commit and do cargo test you will see the failures.

I recommend we don't spend too much time on it, and let the sqlx folks handle it. I opened an issue: launchbadge/sqlx#1596

from chiselstrike.

cargo test fails and panics with this commit : a0b5d47

I cannot reproduce that:

% git rev-parse HEAD
a0b5d477e56664ef0eccd22258565b2cf49c44f4
% git clean -fxd
% cargo test
....
Suite Status:

  Passes: 38

from chiselstrike.