Git Product home page Git Product logo

Comments (10)

glommer avatar glommer commented on May 20, 2024 1

this must be optional. Something we work well without (in which case we show the result of chisel describe), but better with it (in which case we show the swagger API)

from chiselstrike.

penberg avatar penberg commented on May 20, 2024

@dekimir Suggest to add TypeScript decorators for describing the shape of the endpoint inputs and outputs.

from chiselstrike.

glommer avatar glommer commented on May 20, 2024

@mpdehaan just opened this, which may be relevant, Pekka : #983

from chiselstrike.

penberg avatar penberg commented on May 20, 2024

Update: pretty much everybody hits the issue of not finding the correct URL for their endpoints when deploying to the ChiselStrike platform. We need this introspection support to show the endpoints in the web UI.

from chiselstrike.

glommer avatar glommer commented on May 20, 2024

Although OpenAPI would be nice, this is not strictly necessary to solve the user's issue.
We can show the output of chisel describe <version> in the frontend. This will show which endpoints are available, which models, and which policies (which openAPI wouldn't show anyway).

It may be advisable to change that output to json so we can show models, endpoints and policies separately.

That's not to say OpenAPI won't make things better (as it will include documentation for the endpoints as well), but we should do something to show the output of describe as well.

from chiselstrike.

penberg avatar penberg commented on May 20, 2024

@glommer OpenAPI is not an issue at all here. I can trivially generate an OpenAPI JSON with the endpoint paths. The real issue is that those paths don't translate into meaningful developer experience. You need to know what HTTP methods they support at minimum and preferrably you should also know what kind of parameters they accept.

You do, however, have a point that perhaps we should indeed do something simple now to address the issue of people tripping over wrong URLs all the time.

@glommer Would you prefer chisel describe and some backend wrapping or shall we go for simple OpenAPI directly, which shows the paths, but not the HTTP methods?

from chiselstrike.

glommer avatar glommer commented on May 20, 2024

if we can generate basic openapi skeletons that just show the endpoint names without user change, then we can do it. (I don't know enough).

Otherwise we should go with the describe route

from chiselstrike.

penberg avatar penberg commented on May 20, 2024

There's now preliminary support for OpenAPI added in commit a3e5944

from chiselstrike.

mpdehaan avatar mpdehaan commented on May 20, 2024

(ignore my comments I deleted on this one, seeing I thought it was the other ticket that got closed)

from chiselstrike.

penberg avatar penberg commented on May 20, 2024

I am closing this as we support OpenAPI. There's a follow-up issue #1071 to make the APIs more discoverable.

from chiselstrike.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.