Git Product home page Git Product logo

Comments (6)

kdere avatar kdere commented on July 1, 2024 1

OK, I will give it a try (tomorrow).

from chiantipy.

kdere avatar kdere commented on July 1, 2024

the ion Class is used in ioneq to calculate an ionization equilibrium from the ionization rates. Maybe it does not have to be subclassed if it already knows about ion. This is something I am not sure of.

from chiantipy.

wtbarnes avatar wtbarnes commented on July 1, 2024

Yes it is used in the ionization equilibrium calculation (in the calculate method) but I think it is a bit confusing to subclass the single ion class in an object that represents multiple ions.

from chiantipy.

kdere avatar kdere commented on July 1, 2024

how else could we do it -- to get the ionization and recombination rates?

from chiantipy.

wtbarnes avatar wtbarnes commented on July 1, 2024

The ion object can still be called inside of ioneq without subclassing ion. I think actually everything would be exactly the same, just deleting ion in the class definition or replacing it with object, e.g.

class ioneq:

or

class ioneq(object):

from chiantipy.

wtbarnes avatar wtbarnes commented on July 1, 2024

Fixed by #90

from chiantipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.