Git Product home page Git Product logo

Comments (6)

wtbarnes avatar wtbarnes commented on July 19, 2024

Yes I think you are correct in that the label on this plot is not correct as this gives units of erg s^-1 cm^5

The radiative loss rate is typically reported in units of erg cm^3 s^-1 such that $\Lambda n^2$ gives the volumetric radiative loss rate (for a plasma at density $n$) in units of erg cm^-3 s^-1.

I believe the free-bound loss should also have units of erg cm^3 s^-1 and so you would be correct on that count as well. @kdere can you confirm this?

from chiantipy.

kdere avatar kdere commented on July 19, 2024

I agree that the label is not correct. What is plotted is Lambda and Lambdan_en_H gives the radiative loss rate per unit volume erg cm^-3 s^-1.

The units for Lambda are erg cm^3 s^-1, and the same goes for the free-bound loss rate

from chiantipy.

wtbarnes avatar wtbarnes commented on July 19, 2024

Ok so it seems that the units listed in the plot labels and docstrings in several places need to be fixed. @smoon24 would you mind listing all of the places where you've found these inconsistencies and adding to it as you find more? These could all be fixed in a single PR.

from chiantipy.

sanghyukmoon avatar sanghyukmoon commented on July 19, 2024

I used Chianti for coursework by now, so I'm afraid whether if I can find more. I just have checked functions related to RadLoss and found that boundBoundLoss method in Ion.py seems to has similar error. Docstring says it returns loss rate in unit of erg cm^-3 s^-1, which should be erg cm^3 s^-1. And it might be better to add unit in the docstring of freeFreeLoss and twoPhotonLoss for consistency. Thanks!

from chiantipy.

wtbarnes avatar wtbarnes commented on July 19, 2024

Thanks for your feedback @smoon24. If you happen to come across any more of these inconsistencies, feel free to list them here. We'll keep this issue open until these get fixed.

from chiantipy.

kdere avatar kdere commented on July 19, 2024

Yes, this is one of the things I need to get to. I think it is also on the QuickStart page and notebook

from chiantipy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.