Comments (6)
Yes I think you are correct in that the label on this plot is not correct as this gives units of erg s^-1 cm^5
The radiative loss rate is typically reported in units of erg cm^3 s^-1 such that
I believe the free-bound loss should also have units of erg cm^3 s^-1 and so you would be correct on that count as well. @kdere can you confirm this?
from chiantipy.
I agree that the label is not correct. What is plotted is Lambda and Lambdan_en_H gives the radiative loss rate per unit volume erg cm^-3 s^-1.
The units for Lambda are erg cm^3 s^-1, and the same goes for the free-bound loss rate
from chiantipy.
Ok so it seems that the units listed in the plot labels and docstrings in several places need to be fixed. @smoon24 would you mind listing all of the places where you've found these inconsistencies and adding to it as you find more? These could all be fixed in a single PR.
from chiantipy.
I used Chianti for coursework by now, so I'm afraid whether if I can find more. I just have checked functions related to RadLoss and found that boundBoundLoss method in Ion.py seems to has similar error. Docstring says it returns loss rate in unit of erg cm^-3 s^-1, which should be erg cm^3 s^-1. And it might be better to add unit in the docstring of freeFreeLoss and twoPhotonLoss for consistency. Thanks!
from chiantipy.
Thanks for your feedback @smoon24. If you happen to come across any more of these inconsistencies, feel free to list them here. We'll keep this issue open until these get fixed.
from chiantipy.
Yes, this is one of the things I need to get to. I think it is also on the QuickStart page and notebook
from chiantipy.
Related Issues (20)
- Error on running provided jupyter notebooks in the repo HOT 3
- line identifications in spectrum plot HOT 13
- Ability to give custom abundance files HOT 8
- Error while using spectrum with elementList only when all the ions are not present in the masterlist HOT 7
- Unexpected behavior when setting minAbund lower than lowest abund HOT 3
- Error when giving "Zn" in elementlist HOT 2
- How much memory does the mspectrum process consumes? HOT 1
- Chianti is taking more threads than specified HOT 2
- Clarify emission measure units in the function documentations. HOT 2
- Question: Support for photons/keV completed? HOT 10
- Getting spectrum from Ch.spectrum without smoothing/filtering HOT 4
- IDL and ChiantiPy gives different results. HOT 4
- Possible typo in function's documentation HOT 1
- NaNs generated when calculating spectra under certain conditions HOT 9
- Upload 0.15.1 to PyPI HOT 3
- Non-ionization equilibrium? HOT 2
- Unable to load ioneq HOT 10
- Two-photon calculation? HOT 1
- Problem with mspectrum? HOT 9
- Unable to import ChiantiPy.core as ch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chiantipy.