Comments (7)
I have just received my IDL license but have not installed it - probably today. If you want to keep looking at this, go ahead. I have a high regard for Peter's programming. I am now hoping to do the ionization cross-sections/rates by comparing to what I did in IDL
from chiantipy.
Yes I was using the IDL code as the baseline. I will try to fix this soon. I think it should be a pretty simple patch.
from chiantipy.
OK, that is fine. I just got my IDL license installed but have not set up everything yet.
from chiantipy.
In the p2eRatio
method, self.EDensity
is set as the numerator in the expression used to calculate the proton to electron ratio (link). If eDensity
is set when the ion
object is instantiated, this is overridden.
What is the reason for setting the EDensity attribute here? It seems that in the case where eDensity
is not set, this results in self.EDensity
being set incorrectly.
from chiantipy.
That bit of code where
self.EDensity = edensity
definitely does not look right. self.EDensity should never be overwritten
Do you want to continue with this or me? It is fine with me if you do it.
from chiantipy.
I can fix this when I implement the proposed changes to the p2eRatio
method.
from chiantipy.
Closing as this is Fixed by #74
from chiantipy.
Related Issues (20)
- Error on running provided jupyter notebooks in the repo HOT 3
- line identifications in spectrum plot HOT 13
- Ability to give custom abundance files HOT 8
- Error while using spectrum with elementList only when all the ions are not present in the masterlist HOT 7
- Unexpected behavior when setting minAbund lower than lowest abund HOT 3
- Error when giving "Zn" in elementlist HOT 2
- How much memory does the mspectrum process consumes? HOT 1
- Chianti is taking more threads than specified HOT 2
- Clarify emission measure units in the function documentations. HOT 2
- Question: Support for photons/keV completed? HOT 10
- Getting spectrum from Ch.spectrum without smoothing/filtering HOT 4
- IDL and ChiantiPy gives different results. HOT 4
- Possible typo in function's documentation HOT 1
- NaNs generated when calculating spectra under certain conditions HOT 9
- Upload 0.15.1 to PyPI HOT 3
- Non-ionization equilibrium? HOT 2
- Unable to load ioneq HOT 10
- Two-photon calculation? HOT 1
- Problem with mspectrum? HOT 9
- Unable to import ChiantiPy.core as ch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chiantipy.