p2eRatio() method in ion class gives incorrect results at low temperatures about chiantipy HOT 7 CLOSED

I have just received my IDL license but have not installed it - probably today. If you want to keep looking at this, go ahead. I have a high regard for Peter's programming. I am now hoping to do the ionization cross-sections/rates by comparing to what I did in IDL

from chiantipy.

Yes I was using the IDL code as the baseline. I will try to fix this soon. I think it should be a pretty simple patch.

from chiantipy.

OK, that is fine. I just got my IDL license installed but have not set up everything yet.

from chiantipy.

In the p2eRatio method, self.EDensity is set as the numerator in the expression used to calculate the proton to electron ratio (link). If eDensity is set when the ion object is instantiated, this is overridden.

What is the reason for setting the EDensity attribute here? It seems that in the case where eDensity is not set, this results in self.EDensity being set incorrectly.

from chiantipy.

That bit of code where
self.EDensity = edensity
definitely does not look right. self.EDensity should never be overwritten
Do you want to continue with this or me? It is fine with me if you do it.

from chiantipy.

I can fix this when I implement the proposed changes to the p2eRatio method.

from chiantipy.

Closing as this is Fixed by #74

from chiantipy.