Comments (10)
You are right again. I have to clean up ipyMspectrum since there is now a lot of commented out code trying to get it to work again. I have also made a few changes in the ionization functions as they are returning incorrect values. I am in the process of buying and IDL(!) license to try to sort this out.
So, let me do this and then do a complete circle through my fork and through the upstream and back and then you should be free to work on this. thanks!
from chiantipy.
Thanks that sounds great! I'll wait from the Ok from you.
As an aside, it may be helpful to open a PR against the upstream repo while you're implementing your changes so that others can see what you're currently working on and avoid working on those same files/lines of code.
from chiantipy.
I am done for the time being. What is a PR?
from chiantipy.
Ah sorry. PR=pull request.
from chiantipy.
I should have figured that out. I did several PRs and all of the reposes at at the same commit level
from chiantipy.
Ok. I'll open up a PR soon Re: some cleanup of the ion class first.
from chiantipy.
I see a pull request but also your statement that it is not ready. Let me know when to do the pull request
from chiantipy.
I just tried to do a pull request 60 for a file with minor editing. It did not build and seems that the problems was in fetching the CHIANTI database. Why this should happen now, I don't understand. I just previously did a PR for the quickstart notebook and there was no problem
from chiantipy.
this is the end of the raw Travis log
$ mkdir -p $XUVTOP
$ curl -L http://www.chiantidatabase.org/download/CHIANTI_8.0.2_data.tar.gz | tar xz -C $XUVTOP
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
4 254M 4 12.3M 0 0 2345k 0 0:01:51 0:00:05 0:01:46 2529k
curl: (18) transfer closed with 253878598 bytes remaining to read
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
from chiantipy.
Closing. Seems like a lot of this has been taken care of. We can take care of commented out blocks of code as we find them and address any specific issues when they come up.
from chiantipy.
Related Issues (20)
- AttributeError: module 'ChiantiPy.tools.data' has no attribute 'Abundance' HOT 27
- conda-forge package HOT 4
- KeyError on windows 10 HOT 5
- Error on running provided jupyter notebooks in the repo HOT 3
- line identifications in spectrum plot HOT 13
- Ability to give custom abundance files HOT 8
- Error while using spectrum with elementList only when all the ions are not present in the masterlist HOT 7
- Unexpected behavior when setting minAbund lower than lowest abund HOT 3
- Error when giving "Zn" in elementlist HOT 2
- How much memory does the mspectrum process consumes? HOT 1
- Chianti is taking more threads than specified HOT 2
- Clarify emission measure units in the function documentations. HOT 2
- Question: Support for photons/keV completed? HOT 10
- Getting spectrum from Ch.spectrum without smoothing/filtering HOT 4
- IDL and ChiantiPy gives different results. HOT 4
- Possible typo in function's documentation HOT 1
- NaNs generated when calculating spectra under certain conditions HOT 9
- Upload 0.15.1 to PyPI HOT 3
- Non-ionization equilibrium? HOT 2
- Unable to load ioneq HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chiantipy.