Comments (6)
As it is, is is useful for just quickly trying to find what temperature produces the maximum Gofnt for a line or 2 that you know.
When I try to interpret a set of line intensities, I associate the observed intensities with the ion.Intensity dict by way of closest wavelength. However, how to do this is not obvious to the user. I need to see exactly what the user is getting in .Intensity vs Gofnt
So, I would say keep gofnt as it is, or rename it, and find a way to either document how to associate contribution function with a given set of lines.
from chiantipy.
In general, I think the focus should be on returning as much information as possible to the user. As it stands now, the user is only returned a small number of lines and the need to pick lines in the GUI (or CLI) and then plot the gofnt makes non-interactive use of this method difficult.
Provided the user is returned the emissivity array and the associated wavelengths, it should be very simple (e.g. using np.sort
and/or np.where
) to find the top lines. We could include an example of this in the docstring.
In summary, three suggestions for overall improvement of this method:
- Remove wavelength range selection. This does not save time and again can easily be done by the user.
- Remove all plotting and GUI/CLI selections
- Add example in the docstring for selecting top lines based on emissivity values
I'm willing to take care of these changes.
from chiantipy.
I think we should add an additonal method such as gofntAll or something like that that does what you say. I would like to keep the current gofnt, we could rename it something like gofntInteract but I find it very useful.
from chiantipy.
I wonder if it might make more sense to place all of the interactive functionality in ion
in a separate class, e.g. ionInteract
(or something like that).
This would mean removing all plotting commands and anything that involves a selection dialog.
from chiantipy.
I would prefer to keep it all in ion. There really are not all that many interactive methods and I would rather just have one main import.
from chiantipy.
I think the .intensity method provides everything you need for the gofnt of all or a set of lines from a given ion. It is just not called that.
from chiantipy.
Related Issues (20)
- AttributeError: module 'ChiantiPy.tools.data' has no attribute 'Abundance' HOT 27
- conda-forge package HOT 4
- KeyError on windows 10 HOT 5
- Error on running provided jupyter notebooks in the repo HOT 3
- line identifications in spectrum plot HOT 13
- Ability to give custom abundance files HOT 8
- Error while using spectrum with elementList only when all the ions are not present in the masterlist HOT 7
- Unexpected behavior when setting minAbund lower than lowest abund HOT 3
- Error when giving "Zn" in elementlist HOT 2
- How much memory does the mspectrum process consumes? HOT 1
- Chianti is taking more threads than specified HOT 2
- Clarify emission measure units in the function documentations. HOT 2
- Question: Support for photons/keV completed? HOT 10
- Getting spectrum from Ch.spectrum without smoothing/filtering HOT 4
- IDL and ChiantiPy gives different results. HOT 4
- Possible typo in function's documentation HOT 1
- NaNs generated when calculating spectra under certain conditions HOT 9
- Upload 0.15.1 to PyPI HOT 3
- Non-ionization equilibrium? HOT 2
- Unable to load ioneq HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chiantipy.