checksum / critic.sh Goto Github PK

Testing frameworks also need tests!

_output_contains is grep'ing for all following args ("$*") which breaks if you specify an optional message

Example:
Given a method that just:
echo "Gimme some foo"

Happy path:
_assert _output_contains "foo"

Unhappy path:
_assert _output_contains "foo" "there is foo"

Changing the _output_contains function to:
grep -Fqi "$1" <<< "$_output"
appears to fix the issue.

The lines covered aren't quite what's expected, especially LF and LH.

Would be great to have a way to support skipping/running only certain test suites/tests. This will be tricky since _describe and _test are run immediately. I can think of two options:

1. CRITIC_SUITE_ONLY, CRITIC_SUITE_SKIP for test suites
2. _only, _skip function to wrap tests

First of all: great work! I especially love the coverage feature.

I put together some circleci tests that runs the test script with different bash versions

• debian: https://github.com/sdolenc/critic.sh/blob/test-bash-verions/.circleci/config.yml
• alpine: https://github.com/sdolenc/critic.sh/blob/test-alpine-bash-versions/.circleci/config.yml

I believe the readme said bash 4.1 and above should work, but I can only get debian versions "buster" (bash 5) and "stretch" (bash 4.4) to pass successfully.

Would you prefer I describe the errors I'm seeing as separate issues or each one within this issue?