Git Product home page Git Product logo

Comments (10)

msekania avatar msekania commented on June 26, 2024 2

@Mik3yZ ,

see the fix #570

Thanks for reporting the issue!

from ansible-collection-checkmk.general.

msekania avatar msekania commented on June 26, 2024 1

Hi @Mik3yZ,

I would say works as intended.

Folder title and path (folder name) are two different parameters.
path (folder name) is and to best of my knowledge should be low case.
title (alias name in folder module) on the other hand, can also contain capital letters.

from ansible-collection-checkmk.general.

msekania avatar msekania commented on June 26, 2024 1

It should be
self.desired["title"] = self.params.get("name", self.desired["name"])

I'll make corrections

from ansible-collection-checkmk.general.

Mik3yZ avatar Mik3yZ commented on June 26, 2024

Hi @msekania

Maybe my description was a bit off, changed it to reflect what i mean. Hope this makes thing clearer.

from ansible-collection-checkmk.general.

Mik3yZ avatar Mik3yZ commented on June 26, 2024

So, to come back to your last sentence @msekania, title (alias name in the module) is parsed through function _normalize_path, and thus alway transformed to lowercase.

from ansible-collection-checkmk.general.

msekania avatar msekania commented on June 26, 2024

So, to come back to your last sentence @msekania, title (alias name in the module) is parsed through function _normalize_path, and thus alway transformed to lowercase.

lines 220-221: _normalize_path(...) is called with a parameter path, hence path is parsed with _normalize_path(...) not the name (alias title).

from ansible-collection-checkmk.general.

Mik3yZ avatar Mik3yZ commented on June 26, 2024

true, however it does set (self.desired["parent"], self.desired["name"]) with that processed value. please run my example with 4.3.1 and see for yourself.

from ansible-collection-checkmk.general.

msekania avatar msekania commented on June 26, 2024

self.desired["title"] = self.params.get("title", self.desired["name"])

states it explicitly what goes to title

name parameter of the module aliases title

name=dict(
type="str",
required=False,
aliases=["title"],
),

from ansible-collection-checkmk.general.

Mik3yZ avatar Mik3yZ commented on June 26, 2024

yes, i saw that too. however i do get only lowercase names while creating the folders.

i would then say line 220 needs to be changed from:

(self.desired["parent"], self.desired["name"]) = self._normalize_path(
to
(self.desired["parent"], self.desired["path"]) = self._normalize_path(

from ansible-collection-checkmk.general.

msekania avatar msekania commented on June 26, 2024

yes, i saw that too. however i do get only lowercase names while creating the folders.

i would then say line 220 needs to be changed from:

(self.desired["parent"], self.desired["name"]) = self._normalize_path( to (self.desired["parent"], self.desired["path"]) = self._normalize_path(

self.desired["title"] = self.params.get("title", self.desired["name"])
No, actually that's fine, because if title is not defined self.desired["name"] folder is a default name

problem is somewhere else, because self.params.get("title") is Null instead of Name.

from ansible-collection-checkmk.general.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.