Git Product home page Git Product logo

Comments (6)

Max-checkmk avatar Max-checkmk commented on July 4, 2024

Hi Beni,

thank you very much for this very well described problem.
I will look into this. As you already wrote the steps to reproduce this need some work, so please don't expect a solution within a few days.

I would suggest not to remove this option, but to handle the redirect properly.
If it's a bug in the API, we have to fix it there anyway.

KR,
Max

from ansible-collection-checkmk.general.

Max-checkmk avatar Max-checkmk commented on July 4, 2024

Hi @hb9hnt,

i know that your example is about the activation endpoint, but it looks like the issue we already have with #414 is the same. Can you confirm this?

KR,
Max

from ansible-collection-checkmk.general.

hb9hnt avatar hb9hnt commented on July 4, 2024

Hey @Max-checkmk

I do agree that the cause of the issue is the same: calling an API endpoint which possibly returns a 302 to a background job. However I don't agree that the two issues are the same, because the discovery endpoint domain-types/service_discovery_run/actions/start/invoke doesn't give you the option to set redirect: false and make the request synchronous.

IMHO solving this issue is a lot easier than fixing #441 and the resolution that makes sense for #441 might not applicable for the activation endpoint described here.

However, you know the inner workings of Checkmk way better than I do. If you already see a solution that's applicable to both endpoints I'm interested in how you'd solve it.

--Beni

from ansible-collection-checkmk.general.

Max-checkmk avatar Max-checkmk commented on July 4, 2024

Hi Beni,

i just had a customer ticket where we had the exact same problem.
The API answers with the same protocol in which the request came in.
In this case the system apache wasn't configured to forward the https to the site apache.

Could you please check if your system apache is configured like described here?
https://docs.checkmk.com/latest/en/omd_https.html?lquery=apache#httpsredirect

It's about those lines:
<IfModule headers_module>
RequestHeader set X-Forwarded-Proto expr=%{REQUEST_SCHEME}
RequestHeader set X-Forwarded-SSL expr=%{HTTPS}
</IfModule>

KR,
Max

from ansible-collection-checkmk.general.

hb9hnt avatar hb9hnt commented on July 4, 2024

Hey Max

I can confirm that this header was missing from my config. I added the header. At the moment I don't have the opportunity to test this, but I think we can assume that this issue doesn't need fixing.

Thank you and regards

Beni

from ansible-collection-checkmk.general.

robin-checkmk avatar robin-checkmk commented on July 4, 2024

Thanks for the update guys! 🙏

I will close this issue then for now, if the issue remains, feel free to re-open it @hb9hnt. ✌️

from ansible-collection-checkmk.general.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.