chartmogul / chartmogul-go Goto Github PK

The API's internal create and list method will retry forever if got the 429 and can not pass the context to the ChartMogul API.

It is VERY DANGEROUS to a SDK and it is not idioms in golang.

In our integration

1. we publish the invoice to the GCP pubsub
2. import to the ChartMogul via a push subscription
3. we have some businesses after requested to the ChartMogul
4. the CGP will abort and retry if the processing takes more than 30s.

And for some reason, we may publish lots of invoice in a short time, and it maybe take more than 30s(because the internal retry) to request to the ChartMogul, the GCP will start a new request to retry, and the old request still be hanged and retry for too many request.

So it will not take much times, all request have to retry for more than 30s when request to the ChartMogul, and all request will failed, and all request will retry, and the system is hanged.

Please consider add the context to the parameters or add the retry time configuration..

Hi Team, hopefully this is right place to ask, if not, I'd appreciate if you can direct me.

I'm the founder of cloudquery.io, a high performance open source ELT framework.

We are interested in a ChartMogul source plugin, but as we cannot maintain all the plugins ourselves, I was curious if this would be an interesting collaboration, where we would help implement an initial source plugin, and you will help maintain it.

This will give your users the ability to sync ChartMogul data to any of their datalakes/data-warehouses/databases easily using any of the growing list of CQ destination plugins.

Best,
Yevgeny

Hello.

I am using your client and sometimes I get this error:

Request error: Post https://api.chartmogul.com/v1/customers/xxx/attributes/custom: http2: stream closed

As one could guess, this is happening when updating custom attributes.
I am using AddCustomAttributesToCustomer method of API structure. API client is initialized once and reused for all connections.
Information from Gopkg.lock:

[[projects]]
  digest = "1:c797a0c58a4a14307d4390b726bbb6da33ef55f94ebf8e6fe418bf9bfb104a89"
  name = "github.com/chartmogul/chartmogul-go"
  packages = ["."]
  pruneopts = "UT"
  revision = "b31285526784d898de6e9eac819739105a8640ef"
  version = "v1.2.5"

Is this a bug?