charlotte-xiao / ncm2mp3 Goto Github PK

View Code? Open in Web Editor NEW

759.0 4.0 150.0 6.53 MB

网易云ncm音乐格式转换为mp3音乐格式工具

Java 100.00%

ncm2mp3's People

Contributors

Stargazers

Watchers

Forkers

qw852654 lauyang kyle-one algo-goer sporeiii sora39831 tuqicz csj1025 linuxyq 0x789 forgottenz kevisyuan lunb0213 s0ulmate chaggle a258997123 smalldye hiyenwong githublinks xuanrandev gyluq shiro-umi charliemiao zyzh2002 wtcl555 saraadkun conanjordan tianer2820 biuea ng-life mneed peng2289 cvedetect iosname fick707 zwb9412 sodacooky theond aforme coolhihi jabingp aniaeee chenlee9876 cyj1109 bill-cc lan-mao dudylan harryg55 xuxiaolong1994 bobbb517 greenpipig loverqi pangyiguang j0hnngwong xiang0818 featherzhong18 momp263 pinkuburu zj1257 miaoyww sanbruno runninginsilence1 nomindtothink jasonhsu5815 guoranjun2 hongjiang cenkaifeng melthaw assassingq aliexliu liudongkai doslin williammei janzee wbaby harrya2023 xiesj fengsha990817 jianxuancao spectre-2022 xym120012 ljq5277 mirrorpersonal jianinghe k53247l2 25933911 tf2jaguar kingwoshi brandon3343 dmbjz guanzzy yanglong116 hyurbanmanager itknight haifongpan akanemaktyo nero-zjf xrunes wclwksn v1sk

ncm2mp3's Issues

希望能单独出一个包

如果能出一个工具包就好了，就是只含解密和封装功能的，GUI和线程调度等其他的都不要

转换速度略慢

转换500多首歌，界面就卡住了，建议是否可以调整为多线程操作，同时界面上要保持能够和用户交互。
当然这个要求可能略显过分，毕竟只是个开源的小工具，这只是个建议，望采纳。

好像这有点问题

.\NCM2MP3\src\main\java\view\view.java:100
貌似掉了个大括号？

Mac上面转换失败

java --version                                                                                                                                                                
openjdk 17 2021-09-14
OpenJDK Runtime Environment Homebrew (build 17+0)
OpenJDK 64-Bit Server VM Homebrew (build 17+0, mixed mode, sharing)

Convert Failed, index out of bound

my NCM music file was retrieved on July 4, 2023. Both running from source code and running with jar file were tried, and both reported the following problem. 10 files were attempted and all failed with similar errors.
The environment was correctly set, those errors happened when converting the music.

Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 26519 out of bounds for length 256
	at com.alibaba.fastjson.util.IOUtils.decodeBase64(IOUtils.java:467)
	at com.alibaba.fastjson.parser.JSONScanner.bytesValue(JSONScanner.java:132)
	at com.alibaba.fastjson.serializer.ObjectArrayCodec.deserialze(ObjectArrayCodec.java:137)
	at com.alibaba.fastjson.parser.deserializer.DefaultFieldDeserializer.parseField(DefaultFieldDeserializer.java:88)
	at com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer.parseField(JavaBeanDeserializer.java:1278)
	at com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer.deserialze(JavaBeanDeserializer.java:893)
	at com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer.parseRest(JavaBeanDeserializer.java:1624)
	at com.alibaba.fastjson.parser.deserializer.FastjsonASMDeserializer_7_Mata.deserialze(Unknown Source)
	at com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer.deserialze(JavaBeanDeserializer.java:287)
	at com.alibaba.fastjson.parser.DefaultJSONParser.parseObject(DefaultJSONParser.java:705)
	... 10 more

I have searched through the issues and got no solution for this (the ArrayIndexOutOfBoundsException). Looks like they have some new tricks?

作者能改一下做成DLL吗？

曾经2.4版本的时候，大概18年，那时刚出NCM格式的时候，吾爱破解论坛上有人做了个DLL解NCM，可以在下载的时候自动完成解密。好处就是比起GUI和命令行这些工具解密后生成新文件这种方式，不会丢失匹配信息，网易云的匹配有些不准确，会导致一部分歌曲匹配不到信息？总之很奇葩····

乱码解决方案之一

Dependency com.alibaba:fastjson, leading to CVE problem

Hi, In /，there is a dependency com.alibaba:fastjson:1.2.79 that calls the risk method.

CVE-2022-25845

The scope of this CVE affected version is ** [,1.2.83)**

After further analysis, in this project, the main Api called is com.alibaba.fastjson.parser.ParserConfig: checkAutoType(java.lang.String,java.lang.Class,int)Ljava.lang.Class;

Risk method repair link : GitHub

CVE Bug Invocation Path--

Path Length : 8

CVE Bug Invocation Path : 
service.Converter: ncm2Mp3(java.lang.String,java.lang.String)Z .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.JSON: parseObject(java.lang.String,java.lang.Class)Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.JSON: parseObject(java.lang.String,java.lang.Class,com.alibaba.fastjson.parser.Feature[])Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.JSON: parseObject(java.lang.String,java.lang.reflect.Type,com.alibaba.fastjson.parser.ParserConfig,com.alibaba.fastjson.parser.deserializer.ParseProcess,int,com.alibaba.fastjson.parser.Feature[])Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.parser.DefaultJSONParser: parseObject(java.lang.reflect.Type,java.lang.Object)Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer: deserialze(com.alibaba.fastjson.parser.DefaultJSONParser,java.lang.reflect.Type,java.lang.Object,int)Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.parser.deserializer.JavaBeanDeserializer: deserialze(com.alibaba.fastjson.parser.DefaultJSONParser,java.lang.reflect.Type,java.lang.Object,java.lang.Object,int,int[])Ljava.lang.Object; .m2/repository/org/projectlombok/lombok/1.18.22/lombok-1.18.22.jar
com.alibaba.fastjson.parser.ParserConfig: checkAutoType(java.lang.String,java.lang.Class,int)Ljava.lang.Class;

Dependency tree--

[INFO] com.charlottexiao123:NCM2MP3:jar:3.1.0
[INFO] +- net.jthink:jaudiotagger:jar:3.0.1:compile
[INFO] +- com.alibaba:fastjson:jar:1.2.79:compile
[INFO] +- org.projectlombok:lombok:jar:1.18.22:compile
[INFO] \- com.formdev:flatlaf:jar:2.0.1:compile

Suggested solutions:

Update dependency version

Thank you very much.

FROM openjdk:8
COPY . /usr/src/myapp
WORKDIR /usr/src/myapp
ENTRYPOINT ["java", "-jar", "NCM2MP3.jar"]

~/music中以及/music中包含.ncm文件
执行错误：

-> % sudo docker run --rm minn/ncm2mp3:v0.1 -h
Usage: java -jar NCM2MP3.jar [command]
If don't add command, there will open NCM2MP3 GUI directly
[Command List]
-v,-view                      : open NCM View GUI(default command)
-c,--convert [path] ...       : convert NCM File in path to ./output directory
-h,-help                      : Help about any command

-> % sudo docker run --rm -v ~/music:/music minn/ncm2mp3:v0.1 -c /music
Output dir is set to: /usr/src/myapp/.:output
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1927)
        at utils.Utils.listAllFiles(Utils.java:56)
        at service.command.ConvertCommand.lambda$handle$0(ConvertCommand.java:24)
        at java.util.ArrayList.forEach(ArrayList.java:1259)
        at service.command.ConvertCommand.handle(ConvertCommand.java:24)
        at service.Interpreter.handleArgs(Interpreter.java:38)
        at main.main(main.java:9)

由于我并不了解开发、代码、以及编程。以上附上了我所有可参考的信息。
但个人判断可能为该处关于输出目录的问题：

NCM2MP3/src/main/java/service/command/ConvertCommand.java

Line 20 in 38835c0

File outputPath = new File("." + File.pathSeparatorChar + "output");

整体预览：

感谢您的工作，以上。