Git Product home page Git Product logo

c-utf8-valid's People

Contributors

chansen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

c-utf8-valid's Issues

" \xe2\x96\x88 " reported as invalid

It seems that if I add the following lines to test.c:

  char src[]=" \xe2\x96\x88 ";
  TEST_UTF8(src, 5, 0, true);

I get

$ cc test.c -o test && ./test 
utf8_valid(" \xE2\x96\x88 ", 5) != true at line 293
Failed 1 tests of 4381826.

I believe the problem is related this line in utf8_valid.h, which I would expect should look maybe as follows:

--- a/utf8_valid.h
+++ b/utf8_valid.h
@@ -70,7 +70,8 @@ utf8_check(const char *src, size_t len, size_t *cursor) {
   unsigned char buf[4];
   uint32_t v;
 
-  for (p = cur;;) {
+  while (1) {
+    p = cur;
     if (cur >= end - 3) {
       if (cur == end)
         break;

Else, for strings larger than 4 characters, p is always pointing to the first character.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.