As I said in the title, send an Update::Done event wh

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Sweep: Send an `Update::Done` event whenever `Update#done` is saved as true about changepack HOT 1 CLOSED

nicieja commented on May 25, 2024 2

Sweep: Send an `Update::Done` event whenever `Update#done` is saved as true

from changepack.

Comments (1)

sweep-ai commented on May 25, 2024

Hey @nicieja,

I've started working on this PR. The plan is to add a callback in the Update model that triggers an Update::Done event whenever Update#done is saved as true. I'll also create a new event handler for this Update::Done event.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

changepack/write/lib/update/on_commit_created.rb

Lines 1 to 38 in 9fe00ff

 # typed: false 

 # frozen_string_literal: true 

 class Update 

 class OnCommitCreated < Handler 

 on ::Commit::Created 

 sig { override.returns Update } 

 def run 

 Update.create( 

 sourced_at: event.commited_at, 

 account_id: event.account_id, 

 commit_id: event.id, 

 name: event.message, 

 type: :commit, 

 changelog:, 

 source:, 

 tags: 

 ) 

 end 

 sig { returns T.nilable(Source) } 

 def source 

 @source ||= Source.find_by(repository_id: event.repository_id) 

 end 

 sig { returns Changelog } 

 def changelog 

 @changelog ||= Account.find(event.account_id).changelogs.first 

 end 

 sig { returns T::Array[String] } 

 def tags 

 [ 

 event.author.fetch(:email) 

 ] 

 end 

 end

changepack/connect/lib/commit/events.rb

Lines 1 to 35 in 9fe00ff

 # typed: false 

 # frozen_string_literal: true 

 class Commit 

 module Events 

 extend ActiveSupport::Concern 

 extend T::Helpers 

 abstract! 

 module Resource 

 include ::Resource 

 included do 

 attribute :id, String 

 attribute :account_id, String 

 attribute :repository_id, String 

 attribute :message, String 

 attribute :author, Hash 

 attribute :commited_at, T::Time 

 end 

 sig { params(commit: Commit).returns Hash } 

 def self.to_event(commit) 

 commit 

 .as_json(only: %i[id account_id repository_id message author]) 

 .symbolize_keys 

 .merge(commited_at: commit.commited_at) # Needed for type safety 

 end 

 end 

 class Created < Event 

 include Resource 

 end 

 end

changepack/write/lib/source/on_team_updated.rb

Lines 1 to 27 in 9fe00ff

 # typed: false 

 # frozen_string_literal: true 

 class Source 

 class OnTeamUpdated < Handler 

 on ::Team::Updated 

 delegate :account_id, :name, :status, to: :event 

 delegate :id, to: :event, prefix: :team 

 sig { override.returns T::Boolean } 

 def run 

 return false if source.blank? 

 source.update!( 

 account_id:, 

 team_id:, 

 status:, 

 name: 

 ) 

 end 

 sig { returns T.nilable(Source) } 

 def source 

 @source ||= Source.find_by(team_id:) 

 end 

 end

changepack/write/lib/source/on_repository_updated.rb

Lines 1 to 27 in 9fe00ff

 # typed: false 

 # frozen_string_literal: true 

 class Source 

 class OnRepositoryUpdated < Handler 

 on ::Repository::Updated 

 delegate :account_id, :name, :status, to: :event 

 delegate :id, to: :event, prefix: :repository 

 sig { override.returns T::Boolean } 

 def run 

 return false if source.blank? 

 source.update!( 

 repository_id:, 

 account_id:, 

 status:, 

 name: 

 ) 

 end 

 sig { returns T.nilable(Source) } 

 def source 

 @source ||= Source.find_by(repository_id:) 

 end 

 end

changepack/write/spec/models/post/publish_spec.rb

Lines 5 to 57 in 9fe00ff

 
 class Post 

 describe Publish do 

 let!(:user) { create(:user) } 

 let(:update) { create(:update, :commit, account: user.account) } 

 let(:post) { create(:post, user:) } 

 describe '#publish' do 

 subject(:command) { post.publish(publishable) } 

 let(:publishable) { true } 

 it 'sets status to published' do 

 expect { command }.to change(post, :status).from('draft').to('published') 

 end 

 context 'when reverting' do 

 let(:publishable) { false } 

 let(:post) { create(:post, :published, user:) } 

 it 'sets status back to draft' do 

 expect { command }.to change(post, :status).from('published').to('draft') 

 end 

 end 

 end 

 describe '#attach' do 

 subject(:command) { post.attach(updates) } 

 let(:updates) { [update.id] } 

 it 'sets post on updates' do 

 expect { command }.to change { update.reload.post_id }.from(nil).to(post.id) 

 end 

 end 

 describe '#detach' do 

 subject(:command) { post.detach(except: updates) } 

 let(:updates) { [] } 

 before { update.update!(post:) } 

 it 'removes post from updates' do 

 expect { command }.to change { update.reload.post_id }.from(post.id).to(nil) 

 end 

 context 'when excepting updates' do 

 let(:updates) { [update.id] } 

 it 'does not remove post from updates' do 

 expect { command }.not_to change(update, :post_id) 

 end 

 end 

 end 

 end

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

from changepack.

Sweep: Send an `Update::Done` event whenever `Update#done` is saved as true about changepack HOT 1 CLOSED

Comments (1)

Related Issues (17)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# typed: false
	# frozen_string_literal: true

	class Update
	class OnCommitCreated < Handler
	on ::Commit::Created

	sig { override.returns Update }
	def run
	Update.create(
	sourced_at: event.commited_at,
	account_id: event.account_id,
	commit_id: event.id,
	name: event.message,
	type: :commit,
	changelog:,
	source:,
	tags:
	)
	end

	sig { returns T.nilable(Source) }
	def source
	@source \|\|= Source.find_by(repository_id: event.repository_id)
	end

	sig { returns Changelog }
	def changelog
	@changelog \|\|= Account.find(event.account_id).changelogs.first
	end

	sig { returns T::Array[String] }
	def tags
	[
	event.author.fetch(:email)
	]
	end
	end

	# typed: false
	# frozen_string_literal: true

	class Commit
	module Events
	extend ActiveSupport::Concern
	extend T::Helpers

	abstract!

	module Resource
	include ::Resource

	included do
	attribute :id, String
	attribute :account_id, String
	attribute :repository_id, String
	attribute :message, String
	attribute :author, Hash
	attribute :commited_at, T::Time
	end

	sig { params(commit: Commit).returns Hash }
	def self.to_event(commit)
	commit
	.as_json(only: %i[id account_id repository_id message author])
	.symbolize_keys
	.merge(commited_at: commit.commited_at) # Needed for type safety
	end
	end

	class Created < Event
	include Resource
	end
	end

	# typed: false
	# frozen_string_literal: true

	class Source
	class OnTeamUpdated < Handler
	on ::Team::Updated

	delegate :account_id, :name, :status, to: :event
	delegate :id, to: :event, prefix: :team

	sig { override.returns T::Boolean }
	def run
	return false if source.blank?

	source.update!(
	account_id:,
	team_id:,
	status:,
	name:
	)
	end

	sig { returns T.nilable(Source) }
	def source
	@source \|\|= Source.find_by(team_id:)
	end
	end


	class Post
	describe Publish do
	let!(:user) { create(:user) }
	let(:update) { create(:update, :commit, account: user.account) }
	let(:post) { create(:post, user:) }

	describe '#publish' do
	subject(:command) { post.publish(publishable) }
	let(:publishable) { true }

	it 'sets status to published' do
	expect { command }.to change(post, :status).from('draft').to('published')
	end

	context 'when reverting' do
	let(:publishable) { false }
	let(:post) { create(:post, :published, user:) }

	it 'sets status back to draft' do
	expect { command }.to change(post, :status).from('published').to('draft')
	end
	end
	end

	describe '#attach' do
	subject(:command) { post.attach(updates) }
	let(:updates) { [update.id] }

	it 'sets post on updates' do
	expect { command }.to change { update.reload.post_id }.from(nil).to(post.id)
	end
	end

	describe '#detach' do
	subject(:command) { post.detach(except: updates) }
	let(:updates) { [] }

	before { update.update!(post:) }

	it 'removes post from updates' do
	expect { command }.to change { update.reload.post_id }.from(post.id).to(nil)
	end

	context 'when excepting updates' do
	let(:updates) { [update.id] }

	it 'does not remove post from updates' do
	expect { command }.not_to change(update, :post_id)
	end
	end
	end
	end