SourcesController is in app/controllers/sources_controller.rb

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Sweep: Write tests for SourcesController about changepack HOT 4 CLOSED

nicieja commented on May 25, 2024 2

Sweep: Write tests for SourcesController

from changepack.

Comments (4)

sweep-ai commented on May 25, 2024

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact [email protected].

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

from changepack.

sweep-ai commented on May 25, 2024

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact [email protected].

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

from changepack.

sweep-ai commented on May 25, 2024

I'm sorry, but it looks like an error has occured. Try removing and re-adding the sweep label. I'll try again in a minute. If this error persists contact [email protected].

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

from changepack.

sweep-ai commented on May 25, 2024

Hey @nicieja,

I've started working on the PR for writing tests for the SourcesController. The plan is to ensure we have tests that cover the index action and the collection method in the controller. I'll be creating a new file spec/controllers/sources_controller_spec.rb for these tests.

Give me a minute!

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

changepack/write/lib/source/on_repository_created.rb

Lines 1 to 27 in d7daf37

 # typed: false 

 # frozen_string_literal: true 

 class Source 

 class OnRepositoryCreated < Handler 

 on ::Repository::Created 

 delegate :account_id, :name, :status, to: :event 

 delegate :id, to: :event, prefix: :repository 

 sig { override.returns Source } 

 def run 

 Source.create( 

 type: :repository, 

 repository_id:, 

 account_id:, 

 changelog:, 

 status:, 

 name: 

 ) 

 end 

 sig { returns Changelog } 

 def changelog 

 @changelog ||= Account.find(account_id).changelogs.first 

 end 

 end

changepack/write/spec/models/source_spec.rb

Lines 1 to 17 in d7daf37

 # typed: false 

 # frozen_string_literal: true 

 require 'rails_helper' 

 RSpec.describe Source do 

 subject { build(:source, :repository) } 

 it { is_expected.to belong_to(:account) } 

 it { is_expected.to belong_to(:team).optional } 

 it { is_expected.to belong_to(:repository).optional } 

 it { is_expected.to validate_presence_of(:name) } 

 it { is_expected.to validate_presence_of(:type) } 

 it { is_expected.to validate_uniqueness_of(:team_id).scoped_to(:account_id) } 

 it { is_expected.to validate_uniqueness_of(:repository_id).scoped_to(:account_id) } 

 it { is_expected.to validate_inclusion_of(:type).in_array(described_class::TYPES) }

changepack/db/migrate/20230429144455_migrate_sources_from_repositories.rb

Lines 1 to 13 in d7daf37

 class MigrateSourcesFromRepositories < ActiveRecord::Migration[7.0] 

 def change 

 Source.transaction do 

 Repository.find_each do |repository| 

 Source.create!( 

 type: :repository, 

 account_id: repository.account_id, 

 repository_id: repository.id, 

 name: repository.name 

 ) 

 end 

 end 

 end

changepack/app/controllers/repositories_controller.rb

Lines 1 to 24 in d7daf37

 # typed: false 

 # frozen_string_literal: true 

 class RepositoriesController < ApplicationController 

 include Pullable 

 private 

 sig { override.returns Repository } 

 def resource 

 @resource ||= authorized(Repository.all).find(id) 

 end 

 sig { override.returns T::Locals } 

 def item 

 { 

 locals: { repository: resource } 

 } 

 end 

 sig { override.params(_resource: Repository).returns String } 

 def after_transition_path_for(_resource) 

 sources_path 

 end

changepack/app/controllers/sources_controller.rb

Lines 1 to 18 in d7daf37

 # typed: false 

 # frozen_string_literal: true 

 class SourcesController < ApplicationController 

 def index 

 authorize! 

 pagy, sources = pagy(collection) 

 render locals: { sources:, pagy: } 

 end 

 private 

 sig { returns Source::RelationType } 

 def collection 

 authorized(Source.includes(:repository, :team).activity.kept) 

 end 

 end

I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind!

from changepack.

Sweep: Write tests for SourcesController about changepack HOT 4 CLOSED

Comments (4)

Related Issues (17)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# typed: false
	# frozen_string_literal: true

	class Source
	class OnRepositoryCreated < Handler
	on ::Repository::Created

	delegate :account_id, :name, :status, to: :event
	delegate :id, to: :event, prefix: :repository

	sig { override.returns Source }
	def run
	Source.create(
	type: :repository,
	repository_id:,
	account_id:,
	changelog:,
	status:,
	name:
	)
	end

	sig { returns Changelog }
	def changelog
	@changelog \|\|= Account.find(account_id).changelogs.first
	end
	end

	# typed: false
	# frozen_string_literal: true

	require 'rails_helper'

	RSpec.describe Source do
	subject { build(:source, :repository) }

	it { is_expected.to belong_to(:account) }
	it { is_expected.to belong_to(:team).optional }
	it { is_expected.to belong_to(:repository).optional }

	it { is_expected.to validate_presence_of(:name) }
	it { is_expected.to validate_presence_of(:type) }
	it { is_expected.to validate_uniqueness_of(:team_id).scoped_to(:account_id) }
	it { is_expected.to validate_uniqueness_of(:repository_id).scoped_to(:account_id) }
	it { is_expected.to validate_inclusion_of(:type).in_array(described_class::TYPES) }

	class MigrateSourcesFromRepositories < ActiveRecord::Migration[7.0]
	def change
	Source.transaction do
	Repository.find_each do \|repository\|
	Source.create!(
	type: :repository,
	account_id: repository.account_id,
	repository_id: repository.id,
	name: repository.name
	)
	end
	end
	end

	# typed: false
	# frozen_string_literal: true

	class RepositoriesController < ApplicationController
	include Pullable

	private

	sig { override.returns Repository }
	def resource
	@resource \|\|= authorized(Repository.all).find(id)
	end

	sig { override.returns T::Locals }
	def item
	{
	locals: { repository: resource }
	}
	end

	sig { override.params(_resource: Repository).returns String }
	def after_transition_path_for(_resource)
	sources_path
	end

	# typed: false
	# frozen_string_literal: true

	class SourcesController < ApplicationController
	def index
	authorize!
	pagy, sources = pagy(collection)

	render locals: { sources:, pagy: }
	end

	private

	sig { returns Source::RelationType }
	def collection
	authorized(Source.includes(:repository, :team).activity.kept)
	end
	end