chalarangelo / 30-seconds-blog Goto Github PK

In the article "How do I use JavaScript to modify the URL without reloading the page?", I came across the code to dot this. For some reason it doensn't work for multiple API's. Is there a way to fix this?

We've updated our color palette in recent months, however old blog infographics still have white backgrounds. Let's fix this.

Affected images:

• typography-example
• js-variable-scope
• js-array-methods
• flexbox-diagram
• chrome-debug-node - could use some framing

Bug description

Opening the blog link https://30secondsofcode.org/blog/p/1 results in 404 page not found error.

Steps to reproduce

Open https://30secondsofcode.org/blog/p/1

Expected behavior

The page should load the blog post

@Chalarangelo I'm not entirely sure what was meant to be done on lines 58-66 of javascript-this.md or else I'd have fixed it and opened a pull request, but it seems unfinished and doesn't return what it claims to.

The section in question is as follows:

Object context

When a function is called as a method of an object, this refers to the object the method is called on. This applies to methods defined anywhere in the object's prototype chain (i.e. own and inherited methods).

const obj = {
  f: function() {
    return this;
  }
};

console.log(f()); // { foo }

While claiming to return { foo }, as currently written it returns ReferenceError: f is not defined. However, even obj.f() wouldn't return { foo }, so I just imagine this example wasn't quite finished when this page was submitted and got overlooked.

https://github.com/30-seconds/30-seconds-blog/blob/master/blog_posts/javascript-shallow-deep-clone.md
current code

let obj = { a: 1, b: { c: 2 } };
let clone = JSON.parseJSON.stringify(obj)); 
clone.b.c = 4;
// obj = { a: 1, b: { c: 2 }}, clone = { a: 1, b: { c: 4 } }

error in line 2, missing (

let clone = JSON.parseJSON.stringify(obj));
// Uncaught SyntaxError: Unexpected token ')'

fix

let clone = JSON.parse(JSON.stringify(obj)); 

I would like to suggest the adjustment of the initCounter's returned method "reset".
By what I've interpreted, it should've reset the value to the initial, please correct me if I got it wrong

current

const initCounter = (start = 0) => {
  let value = start;
  return {
    get: () => value,
    increment: () => ++value,
    decrement: () => --value,
    reset: () => start
  };
}

proposed

const initCounter = (start = 0) => {
  let value = start;
  return {
    get: () => value,
    increment: () => ++value,
    decrement: () => --value,
    reset: () => value = start 
  };
}

https://github.com/30-seconds/30-seconds-blog/blob/master/blog_posts/javascript-object-is-triple-equals.md

error code

1 === 1; // false
Object.is(1, 1); // false

fix

1 === 1; // true
Object.is(1, 1); // true