Git Product home page Git Product logo

Comments (4)

tuyennhv avatar tuyennhv commented on June 30, 2024

curl http://localhost:9596/eth/v1/lodestar/peers shows too many NA peers, which means agentVersion is not set for them https://github.com/ChainSafe/lodestar/blob/v1.15.0/packages/beacon-node/src/network/peers/peersData.ts#L38

from lodestar.

tuyennhv avatar tuyennhv commented on June 30, 2024

looks like it caused by this one https://github.com/ChainSafe/lodestar/pull/6028/files#diff-e50e7caad2bee8b503fd63320dbc6c32e9f90f05aa76b211df989d02030a9aa6R613

it's supposed to get agent version after 1s but right now we try to get agent version immediately right after a peer:connect event cc @nazarhussain

from lodestar.

wemeetagain avatar wemeetagain commented on June 30, 2024

@libp2p/identify now provides a way to manually trigger identify calls. We should use that rather than waiting X seconds and hoping that an identify happened.

should look something like:

libp2p.identify.identify(peerId).then((i) => {
  const agentVersionBytes = i.AgentVersion
  ...
}).catch(...);

We also need to configure the identify module to not automatically trigger identify too.

createLibp2p({
  identify: identify({... // something here

from lodestar.

nazarhussain avatar nazarhussain commented on June 30, 2024

@wemeetagain Looking forward to work on this issue after we release the fix you made libp2p/js-libp2p#2387

from lodestar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.