Git Product home page Git Product logo

Comments (3)

nflaig avatar nflaig commented on August 16, 2024 1

To be clear, seeing that in the logs does not mean anything is wrong?

Yes, there is nothing wrong on your end, this happens if we receive a block from a peer but the blobs are not received within 3 seconds of the slot.

We will then throw this error to trigger unknown block/blobs sync to request the data from others peers

// throw unavailable so that the unknownblock/blobs can be triggered to pull the block
throw new BlockError(block, {code: BlockErrorCode.DATA_UNAVAILABLE});

events.emit(NetworkEvent.unknownBlock, {rootHex, peer: peerIdStr});

But even though we do that, we still log it as an error which I believe we have to handle differently

logger.error("Error receiving block", {slot: signedBlock.message.slot, peer: peerIdStr}, e as Error);

We could consider logging block validation errors due to bad blocks we receive from the network as a warning instead of error, and for this specific case we might even use a debug log as it seems to be quite common error on goerli / holesky.

from lodestar.

ianw11 avatar ianw11 commented on August 16, 2024

To be clear, seeing that in the logs does not mean anything is wrong?

If it continues to be printed, a message after BLOCK_ERROR_DATA_UNAVAILABLE confirming it won't affect operation would be appreciated.

from lodestar.

wemeetagain avatar wemeetagain commented on August 16, 2024

The error log doesn't fit our logging policy. Should probably be a debug level log

from lodestar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.