cgrates / radigo Goto Github PK

The original project had a function DecodeUserPassword() in validation.go. The validation was half done but the password part functional. I tried to to find a part like this in your fork, but couldn't find it. It seems like it should be part of your coder, but you need the shared secret of the connecting instance for decoding - and I think you don't have access to the Secrets struct to use GetSecret() within a codec. What would be your approach to decode the users password?

The NewServer() and NewClient() functions need an additional parameter "Coder" eg from NewCoder() or nil.

The packet of the client request does not need to be created manually if you have NewRequest() and AddAVPWithName() for this.

There is some t.Error stuff from testing that should be log.Fatalln() or similar

The auth.go seems to be a remainder of the original project. The current code uses handleAuth(). You should remove auth.go.

hi!

./main.go:52:99: not enough arguments in call to radigo.NewServer("tcp", "localhost:1813", secrets, dicts, map[radigo.PacketCode]func(*radigo.Packet) (*radigo.Packet, error){...}, nil).ListenAndServe
have ()
want (<-chan struct {})