cgoldsby / tvosmorebutton Goto Github PK

There is no option to set text alignment. I am working with Arabic language. I have to change "label" which is a private variable.

Did you actually publish any versions to the Cocoapods trunk after 1.2.0?

Are there any near term plans to support Swift 4.2 and Xcode 10? The two issues that are stopping me are operators that have been removed (such as &~ and |=). Other remaining issues are mostly renames such as NSAttributedStringKey to NSAttributedString.Key.

What did you do

Set the text more than can be reflected

What did you expect to happen?

The test is displayed partially, and trailing text is displayed completely

Text text text text text text text text text text text text text te
xt text text text text text text text text text text text text text
text text text text text text text text text text text tex... More

What happened instead?

The test is displayed partially, and trailing text is displayed partially

Text text text text text text text text text text text text text te
xt text text text text text text text text text text text text text
text text text text text text text text text text text tex... Mor...

Why did it happen?

Text and trailing text have different attributes, so you need to use NSMutableAttributedString to calculate the height.

func willFit(to size: CGSize,
                 ellipsesString: String = "",
                 trailingText: String = "",
                 attributes: [NSAttributedString.Key: Any],
                 trailingTextAttributes: [NSAttributedString.Key: Any]) -> Bool {

        let attributedString = NSMutableAttributedString(string: self + ellipsesString, attributes: attributes)
        let attributedTrailingString = NSAttributedString(string: trailingText, attributes: trailingTextAttributes)
        attributedString.append(attributedTrailingString)
        
        let boundedSize = CGSize(width: size.width, height: .greatestFiniteMagnitude)
        let options: NSStringDrawingOptions = [.usesLineFragmentOrigin, .usesFontLeading]
        let boundedRect = attributedString.boundingRect(with: boundedSize,
                                                        options: options,
                                                        context: nil)
        return boundedRect.height <= size.height
    }

When integrating TvOSMoreButton into my project, I see that apart from "TvOSMoreButton" it creates an extra target called "TvOSMoreButton-TvOSMoreButton".

It also happens in the Example project in this repo:

What did you do

Focus on TvOSMoreButton
Press remote touch surface to select button and hold, do not release remote "button"
While remote button still not released move focus to another focusable element. Another element is focused
Release remote button

What did you expect to happen?

After switching focus to another element, TvOSMoreButton should stay in unfocused appearance - no highlight

What happened instead?

After focus switched to another element, TvOSMoreButton becomes highlighted

I'm sure the reason is that method applyPressUpAppearance() called without checking isFocused == true

Hi 👋🏻

Really nice project! Definitely going to be using this in a project we're working on. Thought I'd ask but do you have any plans to recreate _TVButtonLockup buttons in UIKit with working labels as the way it's been done in TVML?

Thank you for this library but emojis makes it difficult to understand. They are meaningless and not reachable easily. For example:

Hey, your library is really interesting.

The only problem I found was the README.md, which lacks an Installation Section
I created this iOS Open source Readme Template so you can take a look on how to easily create an Installation Section
If you want, I can help you to organize the lib.

What are your thoughts? 😄

Hi!

I'm using xCode 8.3.3 to build a PopcornTimeTV app for tvOS 10.2.2. The problem is with 'NSAttributedStringKey' (use of undeclared type). Apparently, it's an iOS 11 implementation and xCode doesn't recognize it. It's on String+Truncation.swift and TvOSMoreButton.swift. Maybe it was already updated for xCode 9? Do you know how can I "fix" it?

Thanks very much!

Hi,

Since my Apple TV updated itself to tvOS 11, I've been trying to make PopcornTimeTV work again.
Unfortunately, during compilation this version of TvOSMoreButton causes two errors:

• Type 'NSAttributedStringKey' (aka 'NSString') has no member 'foregroundColor'
• Cannot convert value of type '[NSAttributedStringKey : Any]' (aka 'Dictionary<NSString, Any>') to expected argument type '[String : Any]?'

Any idea how to fix it? I'm still trying to find something online, but it's too specific.

Thank you very much,
Gustavo

EDIT: Using the previous version it compiled just fine, but it would be nice to understand how to fix the latest version.

Hi there, great library.

Please tell me... How can i change "... MORE"?
I want to change to "... NEXT", or something like.

TY!

We have fount error:

1. Type 'NSAttributedStringKey' (aka 'NSString') has no member 'foregroundColor'
2. Type 'NSAttributedStringKey' (aka 'NSString') has no member 'foregroundColor'

in " TvOSMoreButton.swift"

Can you help me to resolve it ?