Git Product home page Git Product logo

Comments (3)

fweimer-rh avatar fweimer-rh commented on June 1, 2024

We are papering over this in Fedora with:

Avoid build failures with future compilers due to a call to the
undeclared TkWmAddToColormapWindows function.  Define _TKPORT because
/usr/include/tk-private/generic/tkPort.h includes "tkUnixPort.h",
but /usr/include/tk-private/unix is not on the include path,
/usr/include/tk-private/unix/tkUnixPort.h is not found, and
the build fails without the #define.

diff --git a/src/cgnstools/tkogl/tkogl.c b/src/cgnstools/tkogl/tkogl.c
index e697e735e85d619d..6e7f1d9723e9debc 100644
--- a/src/cgnstools/tkogl/tkogl.c
+++ b/src/cgnstools/tkogl/tkogl.c
@@ -22,6 +22,10 @@
 #include "printstr.h"
 #include "feedback.h"
 
+/* For TkWmAddToColormapWindows. */
+#define _TKPORT /* Typical installations cannot find tkPort.h. */
+#include <tk-private/generic/tkInt.h>
+
 #ifndef CONST
 # define CONST
 #endif

Not sure if this appropriate upstream. I didn't want to change the build system so that "tkUnixPort.h" can be found.

from cgns.

awoimbee avatar awoimbee commented on June 1, 2024

I understand we need to #include <tk-private/generic/tkInt.h> (unless a TK dark mage wants to help remove the call to TkWmAddToColormapWindows), but #define _TKPORT is a very dirty hack that I don't understand.
On my machine(™) I have both tkPort.h and tkUnixPort.h.

from cgns.

fweimer-rh avatar fweimer-rh commented on June 1, 2024

I understand we need to #include <tk-private/generic/tkInt.h> (unless a TK dark mage wants to help remove the call to TkWmAddToColormapWindows), but #define _TKPORT is a very dirty hack that I don't understand. On my machine(™) I have both tkPort.h and tkUnixPort.h.

In the same directory? What's your Tcl version/distribution?

from cgns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.