cgarling / initialmassfunctions.jl Goto Github PK

Suggest adding the metallicity dependent IMF from Li + 2023.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Distributions created with Distributions.truncated are missing some key methods, like mean, and it's complicated to define new methods for them since the dispatch is non-trivial. Should switch these implementations to custom types.

Since the PowerLawIMF and LogNormalIMF constructors just create normal truncated distributions and not AbstractIMFs, I'm not sure the abstract type actually helps anything. We're not defining any special methods for AbstractIMFs, so that doesn't support the addition of the abstract type either.