cesm-development / cmake_fortran_utils Goto Github PK

Several modules have "_utils" in their name, which doesn't really tell you anything. However, having a module just called "pFUnit" or "Sourcelist" might not be a good idea either. I need to make a decision about this, preferably sooner.

Relatedly, maybe there should be a naming convention for the functions in each module? Renaming "extract_sources" to "sourcelist_extract_sources"; helpful or just verbose?

There is a "declare_Fortran_stop_failure" function for using "stop 1" to signal failure in Fortran, but it is in a file called Compilers.cmake, which is not yet in this repo (and has an over-general name).

We need to do one of the following:

1. Make Compilers.cmake a better fit for this repo and include it.
2. Create a Fortran+CTest utility module that has the module in it (it's not clear whether the pFUnit function should be moved as well; it probably makes more sense to keep it in the pFUnit_utils module).

The TryMPISERIAL.f90 program is supposed to fail to compile to tell PIO that its using mpi-serial. But it does compile with mpi-serial 2.0 (using ifort 13.1.3) so PIO later tries to build without the _MPISERIAL flag set.