Write documentation on using Gerrit workflow about ceres-solver HOT 13 CLOSED

Comment #1 originally posted by sandwichmaker on 2012-08-15T08:02:04.000Z:

It is definitively missing. I am not sure how I can submit a patch to gerrit, as of now...

from ceres-solver.

Comment #2 originally posted by sandwichmaker on 2012-08-15T13:45:07.000Z:

Hi Arnaud,

We have a brief version at

http://code.google.com/p/ceres-solver/wiki/UsingGerrit

Are you able to get going with this?

Sameer

from ceres-solver.

Comment #3 originally posted by sandwichmaker on 2012-08-15T13:53:39.000Z:

Hi Sameer,

I have a gerrit hook set up for another project (I can try to extract related components); but it would be quite nice if you could provide at least a link (to get the hook properly configured).

Thanks,
Arnaud

from ceres-solver.

Comment #4 originally posted by sandwichmaker on 2012-08-15T14:01:56.000Z:

I just added docs for it :)

Feel free to suggest changes to the docs too.

from ceres-solver.

Comment #5 originally posted by sandwichmaker on 2012-08-15T14:07:26.000Z:

Awesome!!

I would say adding one line to add the remote for gerrit would be useful too

git remote add gerrit ......

from ceres-solver.

Comment #6 originally posted by sandwichmaker on 2012-08-15T14:10:31.000Z:

As far as I remember, I did not have to add any remotes.
which repository are you using? did you clone it from googlesource.com?

my git-fu is a bit weak so I maybe offbase here.
Sameer

from ceres-solver.

Comment #7 originally posted by sandwichmaker on 2012-08-15T14:16:44.000Z:

I have cloned it from googlesource.com

$ git remote show
origin

$ git remote show origin

• remote origin
  Fetch URL: https://ceres-solver.googlesource.com/ceres-solver
  Push URL: https://ceres-solver.googlesource.com/ceres-solver
  HEAD branch: master
  Remote branch:
  master tracked
  Local branch configured for 'git pull':
  master merges with remote master
  Local ref configured for 'git push':
  master pushes to master (up to date)

As you can see after cloning the project, there is only one remote correctly set up...

from ceres-solver.

Comment #8 originally posted by sandwichmaker on 2012-08-15T14:20:21.000Z:

I have exactly the same setup in my client, and I am able to push changes to gerrit by using

git push origin HEAD:refs/for/master

from ceres-solver.

Comment #9 originally posted by sandwichmaker on 2012-08-15T14:23:20.000Z:

I just realized the problem. The documentation says

git push gerrit HEAD:refs/for/master

instead, its simpler to just do (which is what I do in practice)

git push origin HEAD:refs/for/master

I have updated the wiki. Thanks for catching this.

from ceres-solver.

Comment #10 originally posted by sandwichmaker on 2012-08-15T14:35:07.000Z:

Also, it is important to make the commit-msg an executable

$ chmod 775 .git/hooks/commit-msg

Thanks!!

from ceres-solver.

Comment #11 originally posted by sandwichmaker on 2012-08-15T14:38:24.000Z:

One last thing (cause I am in the process), one line to mention that you have to complete one Contributor Agreement (in the gerrit interface) and it gets verified and approved, may also be good ;)

When you try to push you get warned anyway...

from ceres-solver.

Comment #12 originally posted by sandwichmaker on 2012-08-15T16:37:58.000Z:

Done.

from ceres-solver.

Comment #13 originally posted by sandwichmaker on 2012-08-17T21:35:16.000Z:

Closing this as the wiki page seems to be sufficient at this point and the git package is getting more support for automating this work.

from ceres-solver.