centurix / pantastic Goto Github PK

After running the command "python pantastic.py --dir test", it is not able to write output file

Traceback (most recent call last):
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/pantastic.py", line 114, in
sys.exit(main())
^^^^^^
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/.venv/lib/python3.11/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/.venv/lib/python3.11/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/.venv/lib/python3.11/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/.venv/lib/python3.11/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/pantastic.py", line 108, in main
pan_manager.scan_file_with_output(file)
File "/Users/jayeshdesai/work-dirs/pci-pal/Pantastic/pantastic/pantastic.py", line 64, in scan_file_with_output
self.output_handle = open(self.output, 'w')
^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected str, bytes or os.PathLike object, not NoneType

Can someone please help me here?

Pantastic seems to be a fantasic piece of software! But I benchmarked it a little bit, and noticed that if it's scanning some very large file(s) (like 10GB+) the Python process uses RAM as much as the file size is. Is that correct, or did I misanalyze it?

I think it would more efficient, if it reads the file in 128KB to 100MB chunks (maybe that could be even configurable parameter), instead of reading the whole file in RAM at once. Or if it does that chunk based reading already, maybe it should free up the used memory immediately after it has scanned that particular chunk (before reading the next one). Of course, in that case, some last bytes from the previous chunk need to remain in the RAM if the PAN is split between two chunks.

Are you planning on porting this to Python3 ?