Undefined Q_NAMESPACE about celestia HOT 8 CLOSED

I forgot to submit some adjustments. Concerns openSUSE, but may also be useful for other penguins:

diff -ruNp a/src/celestia/qt/QtAudioManager.cpp b/src/celestia/qt/QtAudioManager.cpp
--- a/src/celestia/qt/QtAudioManager.cpp
+++ b/src/celestia/qt/QtAudioManager.cpp
@@ -35,7 +35,11 @@ void QtAudioManager::createChannel(int i
     setChannelLoop(id, looped);
     setChannelFile(id, path);
     setChannelNoPause(id, nopause);
+#if QT_VERSION >= QT_VERSION_CHECK(5, 7, 0)
     connect(player, QOverload<QMediaPlayer::Error>::of(&QMediaPlayer::error), this, &QtAudioManager::logError);
+#else
+    connect(player, SIGNAL(error(QMediaPlayer::Error)), this, SLOT(logError(QMediaPlayer::Error)));
+#endif
 }
 
 void QtAudioManager::playChannel(int channel, double vol, bool looped, const char *f, bool nopause) {
diff -ruNp a/src/celestia/qt/QtCelestiaCoreApplication.h b/src/celestia/qt/QtCelestiaCoreApplication.h
--- a/src/celestia/qt/QtCelestiaCoreApplication.h
+++ b/src/celestia/qt/QtCelestiaCoreApplication.h
@@ -5,7 +5,9 @@
 #include <src/celestia/CelestiaCoreApplication.h>
 
 namespace CelestiaQt {
+#if QT_VERSION >= QT_VERSION_CHECK(5, 8, 0)
     Q_NAMESPACE
+#endif
 
     class RenderFlag : public QObject {
         Q_OBJECT

https://build.opensuse.org/package/show/home:munix9:unstable/celestia
https://software.opensuse.org/download.html?project=home:munix9:unstable&package=celestia

from celestia.

I added Q_NAMSPACE when I though it is needed, however later I realized it isn,t but forgot to remove it. Sorry for that.

from celestia.

In any case, we use QT 5.9 to compile Celestia, so it's not important.

from celestia.

You use 5.9 but there are still a lot of systems which use older versions. Debian 9 is a current stable and will be supported for the next ~4 years, Ubuntu 16.04 (EOS in 2021) uses 5.5, Ubuntu 14.04 uses 5.2 (EOS in next year). I don't know about other OSes.

So if your target is only you and some of your friends then you may not care about older OSes but if you target it for wider audience then you should care about other systems.

from celestia.

@375gnu If all this is so, then you are right.
I work only on Windows and for me there is no problem installing any version of QT.
I hope that @pirogronian will fix the problem.

from celestia.

@375gnu @pirogronian I will soon have a new computer and I think I will not install QT 5.9.2 (Windows), if this is not really necessary.
Can I compile Celestia on previous versions? Which version do you recommend to me?
So I can also notice if there are compatibility problems in the future.

from celestia.

I'd like to say that support for Ubuntu 14.04 & Debian 8 shipping 5.2.x and 5.3.x Qt version, but their compilers don't support C++ 11 fully, and we have 2 stable releases for Ubuntu and 1 for Debian, so 5.5 or 5.7 as lowest supported version is a good start. RedHat 7 and Suse 12 have 5.6.2.

I don't know exactly but suspect that OSX users can install any version like Windows users.

So to be sure that Celestia works on Ubuntu 16 (I suppose it's the most popular version) you should have 5.5.x.

from celestia.

@375gnu Goog. Then on the new computer I install QT 5.5 and will report if there are problems with the compilation. Thanks!

from celestia.