setlocale is not thread safe, causing crash due to race about celestia HOT 2 CLOSED

I think we need to be slightly careful here, because at least on Windows, gettext defines setlocale as a macro that calls its own internal functions that provide functionality like LC_MESSAGES (which isn't part of the Windows C library setlocale). So at least the call at startup needs to be setlocale.

We do have quite a few cases of calling setlocale around fmt calls, which are insensitive to locale - this should probably be replaced by using the overload that takes std::locale instead.

from celestia.

We do have quite a few cases of calling setlocale around fmt calls, which are insensitive to locale - this should probably be replaced by using the overload that takes std::locale instead.

yeah I agree, it seems only fmt::format takes locale so we can convert existing ones to use fmt::format. the only other use of setlocale should be in from_chars_impl.

from celestia.