cedricium / amo-cli Goto Github PK

When using either amo featured [flags] or amo search [flags], occasionally the process will lag - a blinking cursor will be shown for about 2 - 3 seconds before the ora prompt is shown. I believe it is because of the numerous requires each command uses, but I'm not sure.

Ideally, once a command is called, the ora spinner should begin without any delay.

Issue seen across all platforms.

Windows does not fully support unicode, thus, displaying emojis or any other character outside of the utf-8 will have issues.

Terminals affected: cmd, Powershell, ConEmu

Known issue with ora: sindresorhus/ora#40

The .blue string color on Powershell is near invisible, making it very hard to read any of amo-cli's output info.

Possible solutions:

• experiment with all the colors to find a nice scheme that will work for a majority of terminals
• create terminal-based color schemes that are picked up using a config file

Noticed this today on a Windows machine, although, I feel like any non-sudo user may also run into this problem if they do not have the correct permissions:

sudo npm install -g amo-cli
/usr/local/bin/amo -> /usr/local/lib/node_modules/amo-cli/bin/amo

> [email protected] postinstall /usr/local/lib/node_modules/amo-cli
> node scripts/postinstall.js

fs.js:905
  return binding.mkdir(pathModule.toNamespacedPath(path),
                 ^

Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/amo-cli/config'
    at Object.fs.mkdirSync (fs.js:905:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/amo-cli/scripts/postinstall.js:18:6)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:573:32)
    at tryModuleLoad (module.js:513:12)
    at Function.Module._load (module.js:505:3)
    at Function.Module.runMain (module.js:701:10)
    at startup (bootstrap_node.js:193:16)
    at bootstrap_node.js:617:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `node scripts/postinstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/camaya/.npm/_logs/2018-05-15T20_13_44_633Z-debug.log

Possible solution:
Node's fs.mkdirSync() accepts a mode parameter - changing this to a higher than default value should allow for anyone's filesystem to create the directory without errors.

Refs: https://nodejs.org/dist/latest-v8.x/docs/api/fs.html#fs_fs_mkdirsync_path_mode

$ amo help search
...
-q, --query        the search query (maximum allowed length is 100 characters
...

Notice the missing end parenthesis 🙃

Don't want to restrict amo-cli to just English speakers / readers - localizing the app using 🌐 i18n should be on the roadmap 👍

When attempting to use amo-cli w/ v0.2.0 and above, the following warnings are thrown:

WARNING: No configurations found in configuration directory:/Users/cedricamaya/config

It's warning that the config file cannot be found in the pwd, which is not where it should be looking for it. Rather, it needs an absolute path to the installed amo-cli package root.

Once I start documenting amo-cli, the ESLint rule require-jsdoc will be crucial. It was temporarily disabled in 9b93f52 in order to pass TravisCI builds, but that's the only scenario where it was needed and can be brought back.