cea-cosmic / pysap-astro Goto Github PK

System setup
OS: macOS v10.15.1
Python version: 3.6.12
Python environment (if any): conda 4.7.12

Describe the bug
The python package sf_tools is missing in the requirements for the astro plugin.

To Reproduce
When doing:
from pysap.plugins.astro.denoising.denoise import denoise

I got the error:
ModuleNotFoundError: No module named 'sf_tools'

Module and lines involved

The sf_tools package is used in 'astro/denoising/noise.py', see:
https://github.com/CEA-COSMIC/pysap-astro/blob/master/astro/denoising/noise.py

Are you planning to submit a Pull Request?

• Yes
• No

Hello,

I was wondering if there was some parameter I could vary using the sparse_deconv_condatvu deconvolution method to reduce ringing artifacts found near bright point sources in my images? I'm currently calling the method as is via:

sparse_deconv_condatvu(image, psf, n_iter=100)

Attached is a screenshot of the result (please ignore the iteration number inset, this was just an example showing the ringing). I've also attached the original image (before deconvolution) for reference. As you can see there are some very strong ringing artifacts found near the bright central point source in my image, I was wondering if there was some parameters I could vary with this method to reduce this ringing effect?

Best,
Mason

Added in #3