Git Product home page Git Product logo

rereddit_frontend's People

Contributors

cdunn6754 avatar

Watchers

 avatar

rereddit_frontend's Issues

Prevent XSS in comment and post bodies

I have 'dangerouslySetInnerHtml' in the post and comment lists. I want to include that styling that is provided by the cool wysiwyg editor. This should be okay because any html typed by a user into the editor will be a part of a string and won't be rendered.

The issue is that the api can still be accessed outside of the frontend. There a consumer could submit a new comment or post with malicious html in the body. Not sure how to stop that.

Add comments in user profile

Currently there is just a "coming soon" banner there. Its a little trickier than it seems because we need to
alter the backend as well. We need to add the post details of each comment to the data. That way the comments can be grouped together into a single entry and links to the post detail page of their post can be added.

This is related to this backend issue

Combine comment in user profile redux slice with those in the comments slice

Currently we store the two types of comments in disparate redux slices. I don't think that's necessary since we will never need both at the same time (caching may not be a bad idea down the road too). The idea would be to use the comments redux slice, that is currently only used for the trees of comments corresponding to the post detail view, to store the comments for the user profile view.

It's a little complicated because the post detail comments are nested by the backend and the user profile comments are just a list of comments that the user has made.

It may be best to use the nested comment serializer for both cases and specify the queryset, i.e. whether we want all comments related to a post or related to a user, with either separate views or POST/GET parameters.

Nesting the user profile comments would almost be nice because then the work of grouping them by post is done in the backend.

Create a child comment on a nascent comment causes a rendering problem

When you create a new comment and then reply to it before the list is reloaded the child will not
render properly. I think that we just need to be sure to add a children property to the comments when they
are first created. In fact that might be something that should be taken care of on the backend for
consistency.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.