Single arg as array about faktory_worker_python HOT 4 CLOSED

The args always has to be an iterable.

In Python, a brackets don't make an array, you need a trailing comma; eg:

client.queue('some_job', args=(single_argument, ), queue='some_job')

if you use the list syntax [] rather than tuple syntax () then you don't need the trailing comma:

client.queue('some_job', args=[single_argument], queue='some_job')

Because () isn't a tuple, then ([single_argument]) and [single_argument] are equal.

from faktory_worker_python.

what about client.queue('some_job', args={"key": "value"}, queue='some_job')?
I believe it won't be interpreted as kwargs, therefore you we shouldn't accept any iterable. Union(Set, List, Tuple) sounds like a good coverage. What do you think?

from faktory_worker_python.

Faktory wont accept a dict for job args, though it would be nice if it did. It needs to be something that can be deserialised to a slice in Go.

Python's json won't serialise a set type, so we should probably pass args through list(..) to exhaust anything thats iterable before sending to faktory.

That does mean that args={"key": "value"} will be sent to faktory as args=("key") though.

from faktory_worker_python.

So the only reason to not raise an error if something other than list or tuple is to support generators?
I believe you can test typing.Iterator to catch generators. IMO, any other types, including dict should raise an error

from faktory_worker_python.