Comments (5)
What you suggested is roughly how I would implement it; only I wouldn't duplicate the existing worker code. Something like this is safer:
def _fail(self, jid: str, exception=None):
super()._fail(jid, exception)
if exception is not None:
honeybadger.context(jid=jid)
honeybadger.notify(exception)
from faktory_worker_python.
Could we use the Worker._fail to send notifications to error monitors.
from faktory_worker_python.
Something like this:
import honeybadger
from faktory import Worker
# Configure Honeybadger
honeybadger.configure(api_key = 'your_api_key')
class HoneybadgerWorker(Worker):
def _fail(self, jid: str, exception=None):
response = {"jid": jid}
if exception is not None:
response["errtype"] = type(exception).__name__
response["message"] = str(exception)
# notify Honeybadger of the exception
honeybadger.context(jid=jid)
honeybadger.notify(exception)
self.faktory.reply("FAIL", response)
ok = next(self.faktory.get_message())
# Now, when you create a new worker class, inherit from HoneybadgerWorker instead of Worker
class MyWorker(HoneybadgerWorker):
# Your worker code goes here
pass
from faktory_worker_python.
One other thing. I have no idea what honeybadger
is, but if you are using threads then this does not look safe to me:
honeybadger.context(jid=jid)
honeybadger.notify(exception)
Feels a little sketchy.
from faktory_worker_python.
Yeah I was wondering about that, in terms of overriding the _fail
behavior. Honeybadger is an error monitoring provider, but not sure on thread safety in this case. I'll have to test it out, thanks for the input!
from faktory_worker_python.
Related Issues (20)
- worker thread got OSError: [WinError 6] The handle is invalid when stop worker from Web UI
- Release 1.0
- Worker crashes if there's an error when fetching new jobs HOT 1
- Getting INFO times out after starting a lot of workers HOT 2
- Example worker restarting itself on 3.9 HOT 6
- Cannot install version 0.5.0 via pip HOT 3
- ImportError: cannot import name 'BrokenThreadPool' for python version less than 3.7 HOT 1
- Flag version >0.5 to only be python 3.7+ compatible HOT 2
- Batch Support HOT 3
- How to use the `at` argument in queue? HOT 1
- Worker heartbeat crashes with "type 'NoneType' is not iterable" HOT 1
- Remove references to `priority` as a job argument
- FaktoryConnectionResetError in Connection.reply
- AttributeError: Can't pickle local object 'ETL_task.<locals>.task' HOT 6
- Explaination on the thread execution model HOT 4
- Make a new release (v1.1) HOT 1
- Access to Job status in Python client for faktory
- BrokenProcessPool error HOT 4
- Slow Job Processing due to Concurrency Architecture HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faktory_worker_python.