Git Product home page Git Product logo

Comments (5)

cdrx avatar cdrx commented on June 25, 2024 1

What you suggested is roughly how I would implement it; only I wouldn't duplicate the existing worker code. Something like this is safer:

    def _fail(self, jid: str, exception=None):
        super()._fail(jid, exception)
        if exception is not None:
            honeybadger.context(jid=jid)
            honeybadger.notify(exception)

from faktory_worker_python.

TonsOfFun avatar TonsOfFun commented on June 25, 2024

Could we use the Worker._fail to send notifications to error monitors.

from faktory_worker_python.

TonsOfFun avatar TonsOfFun commented on June 25, 2024

Something like this:

import honeybadger
from faktory import Worker

# Configure Honeybadger
honeybadger.configure(api_key = 'your_api_key')

class HoneybadgerWorker(Worker):
    def _fail(self, jid: str, exception=None):
        response = {"jid": jid}
        if exception is not None:
            response["errtype"] = type(exception).__name__
            response["message"] = str(exception)
            # notify Honeybadger of the exception
            honeybadger.context(jid=jid)
            honeybadger.notify(exception)

        self.faktory.reply("FAIL", response)
        ok = next(self.faktory.get_message())

# Now, when you create a new worker class, inherit from HoneybadgerWorker instead of Worker

class MyWorker(HoneybadgerWorker):
    # Your worker code goes here
    pass

from faktory_worker_python.

cdrx avatar cdrx commented on June 25, 2024

One other thing. I have no idea what honeybadger is, but if you are using threads then this does not look safe to me:

honeybadger.context(jid=jid)
honeybadger.notify(exception)

Feels a little sketchy.

from faktory_worker_python.

TonsOfFun avatar TonsOfFun commented on June 25, 2024

Yeah I was wondering about that, in terms of overriding the _fail behavior. Honeybadger is an error monitoring provider, but not sure on thread safety in this case. I'll have to test it out, thanks for the input!

from faktory_worker_python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.