cdowdy / bolt-tinypng Goto Github PK

Is it doable? Is it considered? I would like to help to make it happen if possible.

Images uploaded in a sub directory that already exist have the file extension before the UID in the file name:

ie file 1-test-upload-subfolder.jpg exists in the sub directory:

1-test-upload-subfolder.jpg_20170409_58ea5244ad4cf.jpg   

this makes it very "noisy" so I wanna remove it.. also related to #28

example:

should keep the "filter" after a file has been filtered instead of returning to main list.

see bolt/bolt#7483

that gets fixed/updated or bolt developers decide that hey people wanting to fix your undocumented usage of something is something they'll like I'll return to maintaining this.

As of right now if you're not a core developer of bolt good luck having any input.

Wrong: If you choose either fit or cover as a resize method you must provide and with and height.
Correct: If you choose either fit or cover as a resize method you must provide a width and height.

Bob Lauckhart asked about the directories being sorted in the directory tab.

If you have a lot of directories the way they are currently displayed may take up a lot of screen real estate.

They asked if we could sort the directories in Ascending or Descending order*.

Sooooo this issue is here for anyone else to come across and see its being implemented :)

• sorting sub directories can be a pain. Since I have no control over how a person will name their directories, or if they even have sub directories it becomes difficult to sort them. So for now we'll just sort the main Directory and go from there.

Hey,
the ConfigHelper uses PHP7 Features, but in the composer.json is php7 not required

Now that I have the base functionality that I'd use/want I need to refactor this code so its easier to maintain / update and add.

right now I'd like to with time permitting to:

• move the directory logic into a class or method. IE this stuff:

if ( $directory == 'index' ) {
  $fileList = $filesystem->listContents( null, false );
} else {
    $fileList = $filesystem->listContents( $directory, false );
}  

if ( $directory == 'index' ) {
  $newImagePath = $filesPath . '/' . $newImageName;
} else {
  $newImagePath = $filesPath . '/' . $directory . '/' . $newImageName;
}  

if ( $directory == 'index' ) {
  $uploadDir = '';
} else {
  $uploadDir = $directory . '/';
}

• move the flysytem stuff into its own class so we can easily reuse it "more better"

• add optimized, optimized renamed, and uploaded files to the file list from the json response retrieved from the ajax endpoint
  *add option to delete a directory

• add option to copy/clone an image

• add metadata preservation options to the image upload

with time permitting move to a service

clean up templates - they are currently a mess and I know what they do since I built them :) haha

Server Errors (like a server timeout 504) aren't shown in the UI and the buttons are still disabled.

The error is logged in the console but not shown to a user unaware of the console.

I get my site's 404 when trying to open the extension route: /bolt/extend/tinypng/files

Getting the error Variable "title" does not exist in "tinypng.imageoptimization.html.twig" at line 4. when running this extension and accessing the TinyPNG menu. Running Bolt 3.2.14

wrong data to preserve is passed in the handler

in smaller screens the buttons need "finger" space:

When you filter files in a directory and then optimize them the optimized file is placed in the files list and the file you chose is kept in the list:

Allow a user to upload an image, optimize this / these images with the tiny/png/jpg api and restrict those to a specific size.

This would allow developers to enter a config setting that would take very big images - say 4000px by 4000px and on the upload resize those proportionally to a specific size. Like 1200px by 1200px. That way if a client or someone else uploaded big images we wouldn't have to worry about sizes or big ass images.

bolt 3.3 decided to make a breaking change in a minor version. No longer are back end pages access from :

/bolt/extend/backend-page.

Extend has been changed to 'extensions'.

dropzone looks for the preview template with

previewTemplate: document.getElementById('dropzone-preview').innerHTML,

This causes errors on pages without the the upload form

used:

Every once in a while when you batch upload into a directory sometimes the UI gets stuck and doesn't update. All the files successfully upload , get resized and optimized and saved to the server. The UI just gets stuck somewhere in the ether

The method checkAccpetedTypes is misspelled.

I left autodiscover on :) so Dropzone js will try to find our upload form on backend pages that don't use the tinypng api/extension all that jazz.

Specifically:

Uncaught Error: No URL provided.
    at new Dropzone (dropzone.js:440)
    at Function.Dropzone.discover (dropzone.js:1479)
    at Dropzone._autoDiscoverFunction (dropzone.js:1761)
    at HTMLDocument.init (dropzone.js:1730)  

So we'll turn off autodisover since we can't restrict our custom pages/extensions to particular backend pages and init it only when the id of our form is found. Hopefully this doesn't break anything haha.

CHeck to make sure the user has the proper permissions to upload files