ccp-nc / soprano Goto Github PK
View Code? Open in Web Editor NEWSoprano - a Python library to crack crystals!
Home Page: https://ccp-nc.github.io/soprano/
License: GNU Lesser General Public License v3.0
Soprano - a Python library to crack crystals!
Home Page: https://ccp-nc.github.io/soprano/
License: GNU Lesser General Public License v3.0
I would reserve exceptions for internal errors, rather than general invalid user input. e.g. an innocent:
soprano nmr -o test CONGRS_nmr.magres
generates:
Writing output to test
Traceback (most recent call last):
File "C:\Users\PAUL\anaconda3\envs\sopranotest\Scripts\soprano-script.py", line 33, in
sys.exit(load_entry_point('Soprano', 'console_scripts', 'soprano')())
File "C:\Users\PAUL\anaconda3\envs\sopranotest\lib\site-packages\click\core.py", line 1130, in call
return self.main(*args, **kwargs)
File "C:\Users\PAUL\anaconda3\envs\sopranotest\lib\site-packages\click\core.py", line 1055, in main
rv = self.invoke(ctx)
File "C:\Users\PAUL\anaconda3\envs\sopranotest\lib\site-packages\click\core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "C:\Users\PAUL\anaconda3\envs\sopranotest\lib\site-packages\click\core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "C:\Users\PAUL\anaconda3\envs\sopranotest\lib\site-packages\click\core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "d:\dch0ph\ccp-nc\jkshenton-soprano\soprano\scripts\nmr.py", line 351, in nmr
print_results(dfs, output, output_format, verbose)
File "d:\dch0ph\ccp-nc\jkshenton-soprano\soprano\scripts\cli_utils.py", line 510, in print_results
raise ValueError(f'Unknown output format: {output_format}')
ValueError: Unknown output format:
!
I would use sys.exit("error message") for this kind of thing.
I would specifically trap "no file extension" provided to print a helpful message about output type being deduced from file extension (and values accepted).
Could add .txt for tab separated?
Paul
Under Windows license.txt and LICENSE.txt are seen as the same file due to the case insensitive file system - only one file can be unzipped.
The current version of requierments.txt has ASE v 3.16 - this is very out of date. It's a problem for e.g. running tutorials in the cloud via Binder.
The solid state NMR community needs a set of scripts or an easy-to-use command-line interface to perform common post-processing tasks.
Some of the desired functionality includes:
Extract and summarise:
Select by:
Average over:
Query:
(EFG_alpha >10 and EFG_alpha < 60)
Output
Plot
I have started adding in this functionality here: https://github.com/jkshenton/soprano/tree/magrespython-scripts
Minimum periodic distance, Hungarian algorithm for matching, possibly deal with different unit cells.
It might be useful to have a SOAP gene. i.e. have soprano calculate (possibly via another package such as https://github.com/SINGROUP/dscribe) standard machine learning descriptors such as SOAP.
The isotope data (nuclear spin, quadrupole moments etc.) need to be checked/outsourced to an external library with clearer provenance. Perhaps https://github.com/lmmentel/mendeleev ?
Some existing data seems to be wrong: For example, the quadrupole moment on 19F is zero in its ground state, not -94.2 mb as in the https://github.com/CCP-NC/soprano/blob/master/soprano/data/nmrdata.json file... That number appears to be for the 5/2 spin excited state (197 keV above the ground state).
Data on lots of isotopes is missing. e.g. for 8Li, a commonly used isotope in beta-NMR.
Currently the bond_order_pars
gene only allows selection by species. Allow more flexibility.
Add a command line tool to analyse molecular organic crystals and average the NMR tensors of hydrogen atoms belonging to highly mobile groups.
Test case for defectGen
occasionally fails, as some defects seem to be placed too close wrt the given poisson_r
parameter. Could be either an issue with the test or with the functionality.
Currently one can use recursive_mol_label(index, indices, bonds, elems)
to produce a string representation of a structure starting at index
. It would be a nice feature to have a AtomsProperty
for this in soprano.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.