castaglia / proftpd-mod_conf_sql Goto Github PK

when read the configuration in sqlconf_conf they not reinitialise sqlconf_confi read counter at the end of the configuration read.
then when proftpd restart, sqlconf_confi are at the last position and canot send the readed sql configuration (they are readed in new array, the old are not destroy!).

i've modifyed the source to reinitialise sqlconf_confi at array creation (after make_array call)
and use file_handle pool in place of sql_conf pool.
and set to NULL sqlconf_conf at the end of configuration.

this modification ar in my pull request #4

Currently the conf2sql.pl and sql2conf.pl scripts build up the SQL statements to execute, but are not really using prepared statements (especially with placeholders). This means that space-bearing values could very well cause problems.

in documentation at https://htmlpreview.github.io/?https://github.com/Castaglia/proftpd-mod_conf_sql/blob/master/mod_conf_sql.html you don't have sqlite schema example, but seem to exist her: https://github.com/Castaglia/proftpd-mod_conf_sql/blob/master/sqlite-conf.sql

CREATE TABLE IF NOT EXISTS ftpctx (
  id INTEGER PRIMARY KEY AUTOINCREMENT,
  parent_id INTEGER UNSIGNED,
  name TEXT,
  type TEXT,
  value TEXT
);

CREATE TABLE IF NOT EXISTS ftpconf (
  id INTEGER PRIMARY KEY AUTOINCREMENT,
  name TEXT NOT NULL,
  value BLOB
);

CREATE TABLE IF NOT EXISTS ftpmap (
  conf_id INTEGER UNSIGNED NOT NULL,
  ctx_id INTEGER UNSIGNED NOT NULL
);

Add the necessary support for configuring and using SSL/TLS when connecting to the configuration databases.

Update the mod_conf_sql module to use trace logging, where appropriate.

Update the sql2conf.pl script to support SQLite3 databases, which don't have host/server/db names, and provide the relevant SQLite3 schema.

Per @mcarbonneaux , it would be great if mod_conf_sql supported SQLite databases, both in its provided schema examples and the conf2sql.pl Perl script.

As part of the travis-ci builds, this project should include some integration tests, where we make use of the provided Postgres, MySQL, and SQLite database. The test would be something like:

$ ./proftpd -td10 -c sql://...

So that the locally built proftpd is directed to test the configuration the specified databases.