Git Product home page Git Product logo

moped's People

Contributors

cassava avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

moped's Issues

Enhancement: save playlists for future insertion

Move the moped configuration files to:
~/.moped/moped.conf

Create the folder structure:
~/.moped/playlists/

Allow the putting of 'playlists' in the playlists folder. These can then be specified on the command line, and it means that commonly used playlists do not have to continuously be typed up again and again.

Implementation

Filename should end in .mpl
Format of first line in file:
$MopedPlaylist:ID#:Name$

Any lines thereafter should be a moped (search) command.

Example:

$MopedPlaylist:0:default$
a: This artist should be added
!t: But please get rid of this song!
ma: This this this "and this artist too"
eb: '.*Andrea.*'

Bug: Removing everything but XYZ from the playlist

The query

+r<ae:".*" !b: End of Silence>

should not include End of Silence, but it does.
So the list effectively gets cleared.

If we could implement a way to have several lists in memory at a time:

  • playlist
  • media-library

then we could search in both of these... it might be more efficient for more complex queries. If we could then use real SETS based on filenames or something, that would be even better.

It would make the implementation much cleaner.

Enhancement: Preview and choose/pick feature

Implement something like a picker, a flag that shows you everything that it found in the search, all numerated, which then let you choose which songs that you want to add. This saves you one extra command.

In otherwords, instead of executing the following commands:

moped -u a: some random artist
moped <a: some random artist !t: bad track>

one would just run

moped --pick a: some random artist

This is not very critical though, so I would not give it a high priority.

Affects:

  • mopedparser.py

Traceback: File "/usr/lib/moped/mpdclient3.py", line 194

I've been getting this error from a fresh AUR install

Traceback (most recent call last):
File "/usr/lib/moped/mpdclient3.py", line 194, in _readitems
raise StopIteration
StopIteration

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/usr/bin/moped", line 323, in
mpc = mpdcommunal.MpdCommunal(comm)
File "/usr/lib/moped/mpdcommunal.py", line 56, in init
self.update()
File "/usr/lib/moped/mpdcommunal.py", line 71, in update
self.status = self.mpd.status()
File "/usr/lib/moped/mpdclient3.py", line 141, in
return lambda *args: self._docommand(attr, args, retval)
File "/usr/lib/moped/mpdclient3.py", line 149, in _docommand
return retval()
File "/usr/lib/moped/mpdclient3.py", line 261, in _getobject
objs = list(self._readobjects())
File "/usr/lib/moped/mpdclient3.py", line 214, in _readobjects
for key, value in self._readitems():
RuntimeError: generator raised StopIteration

Enhancement: fix the _group_process() function

Fix the _group_process() function so that it uses the new songlist_search() function, which is more cpu efficient, and actually eliminates completely the need to use any of the filter functions of mpdcommunal (a shame I suppose).

Eventually, it may be merged into mpdcommunal, maybe.

Affects:

  • mopedparser.py

Enhancement: Rewrite parsing and processing system

Right now the parsing and processing system using five primary functions:

  • parse_argument_list()
  • _process_group()
  • _parse_group()
  • _process_unit()
  • _parse_unit()

It would be better if we could parse the entire thing once, turn it into some kind of object, and have another method read that object, and do the searches based on information from that object. That way, the code wouldn't be spread all over 5 functions, but clearly modularized into two separate functions.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.