Hello @carloscuesta!

I see the feature to sign commit. But it is signoff commit (-s).

It should be great if I can GPG-sign commit (-S). 🙂

Hello @carloscuesta!

gitmoji -c fails with "Use of const in strict mode" at launch time.

Issue:
Description: "gitmoji -c fails with "Use of const in strict mode" at launch time."
The stack trace is as follows:
○ → gitmoji -c

/usr/lib/node_modules/gitmoji-cli/cli.js:4
const meow = require('meow')
^^^^^
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:945:3

The nodejs version is :

○ → node -v
v0.10.48

OS: Amazon Linux 2012

Error Message:

Use of const in strict mode.

Hello @carloscuesta!

When run gitmoji -i, I got ERROR: Error: ENOENT: no such file or directory, open 'xxxxxx/.git/hooks/prepare-commit-msg'

And gitmoji commit hook created successfully.

But actually, the hook is not created.

If /.git/hook dir not exist, bug happens.

OS: macOS Sierra
gitmoji-cli -v: 1.8.4
Node version: 8.2.1
Error Message:

ERROR: Error: ENOENT: no such file or directory, open '/Users/me/Desktop/g/gitmoji-cli/.git/hooks/prepare-commit-msg'
gitmoji commit hook created successfully.

Hello @carloscuesta!

Issue:
When i rund gitmoji -c i can go though the prompts until the end, but once i am down it hangs until ctrl+c. It then finishes up the commit. I would expect it to commit without a need for a ctrl+c.

OS:
gitmoji-cli -v: 1.3.0
Node version: 7.0.0 and 7.2.1

Hello @carloscuesta!

Signing commits is not a widespread practice yet, so it would help to remember it as a global config. If its set, use that option instead of prompting on each run.

Hello @carloscuesta!

When using gitmoji-cli, I would like to be able to use JIRA references rather than implicitly using github.com ones. This should be a configurable option with the default behaviour being github.com.

You can use JIRA with github repositories. Also Bitbucket cloud and server (from v5) both have emoji support.

I have a pull request ready to go, but please go easy on me - it's my first Node PR! :)

Issue:
Enter a commit and when prompted type a JIRA reference. Validation fails as it expects just a number. The code will then prefix that number always with a #

OS: MacOS + ZSH
gitmoji-cli -v: 1.5.2-dev
Node version:

Hello @carloscuesta!

Issue:
$ gitmoji -c

OS: windows 10 VSC
gitmoji-cli -v: 1.5.6
Node version: v6.9.2

Error Message: ERROR: This directory is not a git repository.

Currently, the cli command such as --command are not working.

🐛 @ https://github.com/carloscuesta/gitmoji-cli/blob/master/cli.js#L66

Hello @carloscuesta!

I find that it would be very convenient to add a emoji search functionality when commiting changes using gitmoji -c.

I am referring to this screen:

It would be very cool if you could start typing an emoji or the description of one and gitmoji automatically started filtering them.

Hello @carloscuesta 😎!

Since a while now, every time I commit (I have the pre-commit hook installed), after it, I get this message:

ERROR: fatal: Unable to create '/Projects/pathname/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

I've tried removing and installing the pre-commit hook, removed gitmoji-cli completely and updated to the most recent version - nothing helps. I encounter the same problem without pre-commit hook and just using the gitmojicommand. When I just commit normally (without gimoji) everything works fine 👌 .

Any ideas?

KR

Hello @carloscuesta!

Issue: The program stops when using 'gitmoji -c' after the hook is constructed

OS: MacOS Sierra version 10.12.6
gitmoji-cli -v: 5.6.0
Node version: v9.3.0

Description: The program stops when finishing the selection of gitmoji -c after the hook is constructed.
bug reproduce:

gitmoji -i
gitmoji -c

After the selection done, the program will stop.

Error Message:
The terminal freezes.

Hello @carloscuesta!

https://github.com/carloscuesta/gitmoji-cli/blob/master/src/gitmoji.js#L99

I'm loving this tool though one thing is really bothering me, it's the fact that when I want to commit gitmoji does a git add . and for me I would like to have the option to opt out of this feature either by passing a flag perhaps?

OS: OSX 10.11.6
gitmoji-cli -v: 1.3.1
Node version: 6.9.5 & 7.4.0

? Choose a gitmoji: 🎨 - Improving structure / format of the code.
? Enter the commit title: add article
? Enter the commit message:
? Issue / PR reference #:
? Signed commit: Yes
ERROR: fatal: Unable to create 'xxxxxx/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

Add init method to the Gitmoji class that creates a prepare-commit-msg file inside of .git/hooks/.

Hello @carloscuesta!

I ran into an issue when using gitmoji-cli through a HTTP corporate proxy.
It seems to be related to this issue on Axios which has been stuck couple months: axios/axios#959

Would you accept a PR to migrate the gitmojiApiClient to another http client ?

Issue:
When using gitmoji-cli through a HTTP proxy, Axios tries to connect to the proxy as an HTTPS proxy.

You can reproduce the issue by setting up a squid proxy:

docker run --name squid -d --restart=always --publish 3128:3128 sameersbn/squid:3.3.8-23
export HTTPS_PROXY=http://localhost:3128
gitmoji -c

OS: Linux
gitmoji-cli -v: 1.8.8
Node version: v9.11.1

Error Message:

ERROR: Network connection not found - EPROTO

Using mocha create a test file that imports the GitmojiClient class and tests the methods.

• Create test.js
• Add tests and use cases.
• search()
• version()
• init()
• commit()
• list()
• Create a npm script to run the tests.

Hello @carloscuesta!

issue

when I try to commit my work using hook, this what it happen

version same as before #71

PS: but the commit working fine

Error Message:

fatal: cannot lock ref 'HEAD': is at 58d35ce02f30d9a95592b7167d4748dea73ad57c but expected 470298be6da12f48a92ae8585e1e236a574d6ec7

Hello @carloscuesta!

Issue:

I dunno if this is just me doing this, but sometimes I modify several files but wanna commit them appart. So I stage some of them and then I run gitmoji -c. However, during its commit stage, the cli runs git add . and as a consequence all my modified files end up in the current commit.

Not a big deal though 😺

OS: Windows 10
gitmoji-cli -v: 1.5.4
Node version: 8.0.0

Thank you ! ✌️

Consider using unicode instead of :emoji:

Referring to that issue

Changes that needs to be made to use unicode instead of :emoji:

{
	choices: gitmojis.map(gitmoji => {
		return {
			name: `${gitmoji.emoji}  - ${gitmoji.description}`,
+			value: gitmoji.code
		};
	})
}
{
	choices: gitmojis.map(gitmoji => {
		return {
			name: `${gitmoji.emoji}  - ${gitmoji.description}`,
-			value: gitmoji.emoji
		};
	})
}

Add a --version / -v option that outputs the pkg.version to the console.

Hello @carloscuesta!

Great work on this - such a great addition to my workflow. I'm running into an issue with using the git hook.

Issue:

I've already set up the git hook per the documentation. When I git commit, the CLI prompts me as intended and works great. I finalize my message, hit enter, and the commit is committed.

Next is the issue - at the same time when I hit enter to submit, the COMMIT_EDITMSG is opened up in my default editor (vscode). Also happening to colleagues who do not have a default editor setup, and it opens the file there in vim.

Ideally this file wouldn't open. Thoughts?

macOS 10.12.4:
gitmoji 1.5.2:
Node v7.8.0:

Hello @carloscuesta!

When trying to run gitmoji -i on Windows I get the error and the hook don't get installed.

OS: Windows 10
gitmoji-cli -v: 1.5.8
Node version: v7.7.4

Error Message:

ENOENT: no such file or directory, open 'E:\project\undefined\.git\hooks\prepare-commit-msg'

Extra Info:

I noticed the path is defined using process.env.PWD, so when I tried getting the value for that:

PS E:\project> echo $PWD

Path
----
E:\project

Hello @carloscuesta!

Hello @carloscuesta!

Issue: After change default NPM directory (for using installs/tools without sudo) I always get same error on any action via gitmoji.
OS: Linux Mint Mate 18.2 (x64_86)
gitmoji-cli -v: ???
Node version: v4.2.6
Error Message:

$ gitmoji -g
/home/toby3d/.local/lib/node_modules/gitmoji-cli/src/gitmoji.js:16
class GitmojiCli {
^^^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:374:25)
    at Object.Module._extensions..js (module.js:417:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/toby3d/.local/lib/node_modules/gitmoji-cli/cli.js:7:20)
    at Module._compile (module.js:410:26)
    at Object.Module._extensions..js (module.js:417:10)

Hello,

Thank you for gitmoji, it's fun and usefull to have an emoji norm to commit message!

1. Default behaviour

> gitmoji
>

Nothing happens when we run the cli without parameter.
I read your code and it's because you run a command only if you have a parameter.

I think it's better to run gitmoji -c by default.

2. Git add

> gitmoji -c
? Choose a gitmoji: ✏️  - Fixing typos.
? Enter the commit title: test
? Enter the commit message: toto
? Issue / PR reference #: 
? Signed commit: No

ERROR: 

Can you check if we added some files before running gitmoji ?
Or can you just display a real error message (for example: "Error: you have to add some files first") ?

3. Commitizen

Do you know the commitizen project ?
They also have a cli : https://github.com/commitizen/cz-cli

At the beginning, I wanted to create a gitmoji config for commitizen but I can't find a repository which only export the gitmojis.json.

4. Contributing

Can we create PRs to fix bugs / add features or you prefer that we add issues ?

When i use gitmoji as git-hook it draws first prompt for emoji and then process ends and default git commit procedure starts (text editor opens asking me to enter my commit message, which is blank, or in case if i specify -m "Commit message" it just commits).

Hello @carloscuesta!

We use backticks ("`") in our commit messages around things like class names, function names etc. However, using backticks in the commit title and description CLI prompts does not appear to be possible, or perhaps I fail to see how it is possible.

Error Message: "Enter a valid commit title"

OS: Ubuntu 16.04 under WSL
gitmoji-cli -v: 1.8.4
Node version: 9.2.0

Thanks in advance!

Edit:

After creating the issue, I found that this is being explicitly checked for in the title guard and message guard. Are there any plans for changing this?
Or rather ... is there anyway I can convince you to change this? 😄

Hello @carloscuesta!

Issue: Since updating to 1.2.1 committing with the hook takes insanely long. After 3 minutes or so I quit the command with Ctrl + c and as you can see on the screenshot below, commit seems to have gone trough but produces an error about locking HEAD. I do have other git hooks configured (pre-commit and pre-push) but using gitmoji <=1.2.x worked just fine. Omitting the --no-verify flag is not relevant to the issue ;)

OS: macOS (Latest RC)
gitmoji-cli -v: 1.2.1
Node version: v7.1.0

Error Message:

Hello @carloscuesta!

Can't get gitmoji to work (at all) in our infrastructure.

I suspect an issue with my proxy (I'm using CNTLM running on localhost:8080, see below).
As far as i could see, the requests from gitmoji-cli do not hit my proxy.
(But I don't see what could be wrong with my config.)

Issue:

> npm install -g gitmoji-cli
(...)
> echo %http_proxy% - %https_proxy%
http://localhost:8080 - http://localhost:8080
> npm config get http-proxy & npm config get https-proxy
http://localhost:8080
http://localhost:8080/
> gitmoji -c
ERROR: Network connection not found - ECONNABORTED

then I have to hit Ctrl+C, and:

TypeError: Cannot read property 'filter' of undefined
    at Object.questions.source.Promise.resolve.gitmojis.filter [as source] (D:\var\npm\node_modules\gitmoji-cli\src\gitmoji.js:146:7)
    at Prompt.search (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\index.js:172:30)
    at Prompt._run (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\index.js:70:8)
    at Prompt.<anonymous> (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\node_modules\inquirer\lib\prompts\base.js:56:10)
    at Prompt.run (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\node_modules\inquirer\lib\prompts\base.js:55:10)
    at null.<anonymous> (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer\lib\ui\prompt.js:78:56)
    at tryCatcher (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:63:31)
    at Defer.subscribeCore (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:2536:37)
    at Defer.tryCatcher (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:63:31)
    at setDisposable (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:2082:46)
readline.js:925
            throw err;
            ^

TypeError: Cannot read property 'filter' of undefined
    at Object.questions.source.Promise.resolve.gitmojis.filter [as source] (D:\var\npm\node_modules\gitmoji-cli\src\gitmoji.js:146:7)
    at Prompt.search (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\index.js:172:30)
    at Prompt.onKeypress (D:\var\npm\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\index.js:228:12)
    at AnonymousObserver.Rx.AnonymousObserver.AnonymousObserver.next (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:1828:12)
    at AnonymousObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:1762:31)
    at AnonymousObserver.tryCatcher (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:63:31)
    at AutoDetachObserverPrototype.next (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:5883:51)
    at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:1762:31)
    at TakeWhileObserver.next (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:5701:17)
    at TakeWhileObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (D:\var\npm\node_modules\gitmoji-cli\node_modules\rx\dist\rx.js:1762:31)

OS: Windows 7 Enterprise SP1
gitmoji-cli -v: 1.5.1
Node version: 4.4.7
npm version: 3.10.3

Error Message: (see above trace)

Hi Carlos,

First of all thanks for such an amazing piece of cake. I'd be great if I could get this to work but unfortunately I am always getting this error:

I've tried also with sudo gitmoji -c but doesn't work either. Any clue of what could be going on here? I've made sure there is no index.lock file in my .git/ folder.

Thank you very much!

Ramón

Hello @carloscuesta!

The plugin fails when i do a commit (In Windows)

Issue:
Just when i put the pull request number in the gitmojii -c command(i havent pull request in my repository, i dont know if is required).

OS: Windows 10
gitmoji-cli -v: 1.8.3
Node version: 6.9.2

Also, i dont see the emojis, could be a problem in Windows.

Error Message:
ERROR: .git/hooks/prepare-commit-msg: line 3: /dev/tty: No such device or address

Greetings and good job @carloscuesta 👍

Hello @carloscuesta!

Gitmoji init command is not recursive inside a git folder.

Issue:
If we have a git repo, then enter some folder inside that repo and run gitmoji --init, gitmoji-cli tell us that the hook was sucessfully created
gitmoji commit hook created successfully..

But it doesn't created the hook.

OS: Deepin OS 15.5 (Linux, Debian based)
gitmoji-cli -v: 1.8.7
Node version: 9.2.0

Error Message:

ERROR: Error: ENOENT: no such file or directory, open '~/.server/gitmoji-test/test/.git/hooks/prepare-commit-msg'

Hello @carloscuesta!

Git commits should have an empty line between the title and the description but currently, there's none:

📝 Add Readme
This readme bla bla #1

should look like

📝 Add Readme

This readme bla bla #1

Hello @carloscuesta 😎!

Issue:

Step to reproduce

? Enter the commit title: Fixing \`yarn run build\` script

Or whatever bash command line you insert between `. Other example :

$ gitmoji -c
? Choose a gitmoji: ✅  - Adding tests.
? Enter the commit title: `echo "foobarbaz"`
? Enter the commit message: 
? Issue / PR reference: 
? Signed commit: Yes
[dev 709eefb] :white_check_mark: foobarbaz

What is expected

A commit message with the selected emoji and text above

Actual Behavior

The ` are removed from the commit message and the command is executed with the output printed inside the commit message.

OS: Archlinux
gitmoji-cli -v: 1.5.5
Node version: v7.10.0

Hello @carloscuesta!
Thanks in advance.

I'm constantly getting an error when trying to commit changes. Also when I use git add --patch all files are getting staged automatically after failing to commit.

Issue started appering after I updated to 1.6.0. there's no .git/index.lock file (it's stated in error message to delete it manually). Rebooting, reinstalling gitmoji-cli or trying to perform actions in a new repo don't help.

Steps to reproduce:

mkdir test && cd test && git init
touch test_file
git add .
gitmoji

OS: Windows 10
gitmoji-cli -v: 1.6.0
Node version: 7.9.0

Error Message:

ERROR: fatal: Unable to create 'project/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

Hello @carloscuesta!

Trying to use the gitmoji cli for the first time and it's not really working :/

OS: macOS 10.12.4
gitmoji-cli -v: 1.5.0
Node version: v7.9.0

Error Message:

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gs
## master...origin/master
 M readme.md

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji
? Choose a gitmoji: 💡  - Documenting source code.
? Enter the commit title: Docs
? Enter the commit message: Testing gitmoji...
? Issue / PR reference #:
? Signed commit: Yes
ERROR:

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   readme.md

no changes added to commit (use "git add" and/or "git commit -a")

~/src/github.com/wayneashleyberry/wayne.cloud master*
❯ gitmoji -c
? Choose a gitmoji: 📝  - Writing docs.
? Enter the commit title: Writing docs.
? Enter the commit message: Just playing around with gitmoji really...
? Issue / PR reference #:
? Signed commit: Yes
ERROR:

Hello @carloscuesta!

my terminal hang/freeze when I use gitmoji -c

Issue:

my step is

1. select emoji
2. enter commit title
3. let message empty
4. let issue empty
5. HANG

example result

? Choose a gitmoji: 🔥  - Removing code or files.
? Enter the commit title: hello world
? Enter the commit message:
? Issue / PR reference:

gitmoji-cli -v: 1.8.1
Node version: v8.5.0

I don't want to sign all my commit but everytime i have to remember that I have to put the n for that value
, it's possible to configure what question ask?
Also by commandline will be not very bad

Hello @carloscuesta!

Noticed some missing emoji using the gitmoji-cli on macOS vs the gitmoji-cli on Windows 10.

Issue:

Missing emoji includes 💡 , 🍻 , and many more.

OS:
gitmoji-cli -v: 1.5.2
Node version: 6.10.2
OS: macOS Sierra 10.12.4

Error Message:

Hello @carloscuesta!

Currently I couldn't find a way to set the config specific for a project or based on command line flags.

It would be useful to have that so one could create standard settings for a given project, across all users.

IMHO gitmoji-cli got for aim to make gitmojis data available for programatic purpose (like a git hook).

In this case, the option --init is not a the right place, I think it should be in gitmoji-commit-hook.

What do you think @carloscuesta?

Hello @carloscuesta!

closing-issues: https://help.github.com/articles/closing-issues-using-keywords/

Moved from gitmoji#114

Hello @carloscuesta!

Issue:

Unable to commit successfully with 🔖.

OS: macOS Sierra 10.12.4
gitmoji-cli -v: 1.5.0
Node version: 7.8.0

Error Message:

ERROR:

Hello @carloscuesta!

Unable to sign a commit in the latest upgrade like the previous version when the option of signing a commit has a default of Y.
The error will not show when not signing one.
If that's the case, the option of signing a commit should be default to n.

ERROR: gpg: skipped "John Doe <[email protected]>": secret key not available
gpg: signing failed: secret key not available
error: gpg failed to sign the data
fatal: failed to write commit object

Issue:

OS:
gitmoji-cli -v: 1.5.3
Node version: 7.10.0

Error Message:

ERROR: gpg: skipped "John Doe <[email protected]>": secret key not available
gpg: signing failed: secret key not available
error: gpg failed to sign the data
fatal: failed to write commit object

It will be useful to make it works offline, as I work often in no-wifi train, I want to be able to commit without internet connection required.

Hello @carloscuesta!

The client isn't working in Android Studio (so I think on IntelliJ as well but haven't tested it)

Issue:
If I run gitmoji -c i don't see the emojis.

Beside of that I got the same error like in #64

OS: High Sierra
gitmoji-cli -v: 1.8.2
Node version: v7.10.0

Hello @carloscuesta!

Something is been going on with my version. Even when I disable automatic git add . this setting seem not to persist. My idea is to transform it into an option -a, if set then it'd add everything, otherwise it'd just commit.

Issue:
Even when I disable automatic git add . this setting seem not to persist

OS: MacOS Sierra
gitmoji-cli -v: 1.6.0
Node version: 8.4.0

Hello @carloscuesta!

Issue:
not work , print network connection not found, but my network is work.

OS: 0.12.3
gitmoji-cli -v:1.5.4
Node version:v7.7.2

➜ mytest git:(master) ✗ gitmoji bug -s
ERROR: Network connection not found - ECONNABORTED
ERROR: undefined
➜ mytest git:(master) ✗ gitmoji -u
ERROR: Network connection not found - ECONNABORTED
➜ mytest git:(master) ✗ gitmoji -v
1.5.4
➜ mytest git:(master) ✗ node -v
v7.7.2
➜ mytest git:(master) ✗ gitmoji -l
ERROR: Network connection not found - ECONNABORTED
ERROR: gitmoji list not found - undefined
➜ mytest git:(master) ✗ curl ip.cn
当前 IP：45.76.50.182 来自：日本 Vultr // is Japan IP
➜ mytest git:(master) ✗