carlelieser / tiper-js Goto Github PK
View Code? Open in Web Editor NEWA small library for creating typing animations.
Home Page: https://carlelieser.github.io/tiper-js/
A small library for creating typing animations.
Home Page: https://carlelieser.github.io/tiper-js/
To ensure the code is consistent, linter could be added, for example eslint with typescript plugins
stopTyping() this method doesn't work
Hi @carlelieser.
A new version of set-interval-async is available with improvements on error handling and including a bug fix. You may see the changes in more detail in the release notes.
I'm reaching out because I noticed an instance of the following pattern in your project, which may lead to undesired results:
const timer = setIntervalAsync(async () => {
// ...
if (/* some condition */) {
await clearIntervalAsync(timer);
}
}, interval);
The code above generates a chaining promise cycle which never resolves, because:
await clearIntervalAsync(timer)
will not resolve until the last execution has finished, ANDawait clearIntervalAsync(timer)
has been resolved.In tiper-js, the pattern is hidden in the following sequence initializeTypingInterval > setIntervalAsync > insertCurrentChar > stopTyping > clearIntervalAsync
. Simply not awaiting clearIntervalAsync
may be enough to avoid this issue, but the right solution will depend on your application's requirements. This didn't surface earlier due to the bug in set-interval-async that has now been fixed in the latest major version.
There are several variables, properties and functions which are not used. Should they be removed / should stay?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.