Reported by DocFred

Describe the bug

Sous iOs/Firefox, si l'on agrandi la vidéo YT en cours de lecture en plein écran, et que l'on en ressort(Echap), le cadre vidéo disparait de la plateforme.
A priori ca se produit que lorsque la vidéo passe un mark de citation, si je lance les 30 premières secondes et qu'il n'y a pas de citation, je ne constate pas le souci

Screenshots

System:

• iOS
• Firefox

We need to think of a way to detect if extension is installed from https://captainfact.io.

A way to achieve that could be to inject a special variable in global scope like redux devtools extension is doing. We could check for that special variable after authenticating user and send a request if the achievement is missing from user.achievements. This involve modifications on extension.

API endpoint doesn't yet exists but will most probably be:

PUT /users/me/achievements/bulletproof

The devDependency eslint-plugin-cypress was updated from 2.1.3 to 2.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-cypress is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Recent webpack migration broke sass styles hot reload, which means page must be refreshed to see a change in styles when developing.

Noticed by Basile

• iPhone 5s
• iOS 10.3.2 (2017)

Bug submitted by Piouscott:

1- Cliquer sur le bouton "+" en bas de page.
2- Dans l'encadré du commentaire, cliquer sur le bouton "Annuler"
Observé:
Le clique sur le bouton "annuler" génère le message d'erreur "Doit faire au moins 10 caractères", et l'encadré n'est pas supprimé. C'est seulement au deuxième clique que l'encardé disparaît
Attendu:
Le clique sur "annuler" devrait avoir le même effet que le clique sur le bouton "X" en bas de page.

Description

Comment text formatter, which ensure we don't put more than one empty line or that we don't put too much consecutives spaces is breaking caret position when trying to insert a consecutive space at the middle. This also appends when trying to insert multiple empty lines.

Expected behavior

Caret should always stay at its position, even if this means allowing multiple consecutive spaces

Platform

Chromium 62.0.3202.62 (Official Build) on Linux (Ubuntu 16.04)

When clicking on "add statement" then scrolling down, some stuff can be confusing: autoscroll is disabled, and user may not understand why. He may not be able to remember he had the form open in the first place.

We can improve this experience by making the bubble menu grey and showing a close icon if statement form is currently active:

Clicking on this cross would close the statement.

The dependency reactjs-popup was updated from 1.3.0 to 1.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

reactjs-popup is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Font awesome randomly show ugly characters instead of icons, while i it successfully loads (no network errors). A simple refresh usually fix the error.

It is not only font awesome, as seen on the bottom right of following screenshot UTF8 quotes are broken too.

The devDependency react-hot-loader was updated from 4.6.5 to 4.7.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-hot-loader is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency enzyme-to-json was updated from 3.3.4 to 3.3.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

enzyme-to-json is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The dependency validator was updated from 10.8.0 to 10.9.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

validator is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

9.5 Mo

6 Mo

There have been updates to the enzyme monorepo:

• • The devDependency enzyme was updated from 3.8.0 to 3.9.0.

• The devDependency enzyme-adapter-react-16 was updated from 1.9.0 to 1.9.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the enzyme group definition.

enzyme is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Describe the bug
When clicking on time-changing links like the carets on statements or the time links video is paused which is pretty annoying when trying to find the right position for a statement.

This may be a regression from YouTube player as we haven't touched this code for some time.

To Reproduce
Steps to reproduce the behavior:

1. Go to a video
2. Click on play
3. Click on Add statement
4. Try to click on the carets or the time mark

Screenshots

System:
Tested on Chrome / Firefox.

Description

Comments with a certain number of flags get reported and are no more returned from the API. Modifications, such as editing a statement or adding a speaker can also be flagged.

To ensure a collective moderation we should create a moderation platform reserved to users with a huge reputation.

Moderators privileges

For each reported comments, moderators have 3 choices:

• Confirm flag => +1
• Not sure => 0
• Abusive flag => -1

Rules

We need at least 3 moderators to vote before taking a decision. Then we generate a score:

score = (nb_confirm - nb_abuse) / total_feedbacks

• If score <= -0.66 => Abusive flag
• If score >= 0.66 => Confirm flag
• Else => Wait to have more feedbacks

Reputation updates

We update reputations depending on this score. But to be fair and not penalize users when decisions are complicated,
we first determine the strength of the moderators consensus with:

consensur_strength = (abs_score - min_val) * (1 / (1 - min_val))

Moderators reward

• A special achievement
• Moderators should gain additional reputation (not too much) when they take the time to check flags

Interface

Moderation platform should take two shapes:

1. Check all flagged comments and actions linked to a video
2. A page where we would get a random action or comment assigned, one at a time

For each action, moderator should be presented a box like this one (extended version here):

This is pretty much what we show on the history page without the Approve / Flag buttons on actions.

• Full page prototype with random actions

• (Bonus) Full page prototype on video collective moderation

Code

Frontend

• app/constants.js => Some action types and entities are defined here.
  If you want to add Comment entity: export const ENTITY_COMMENT = 4
• assets/assets/locales/en/history.json => Actions / Entities translations indexed by their numeric identifier. Again comment type is 4 - you can add it there.

API endpoints (REST)

Methods presented in details deal with actions. We're always posting feedback on an action (ex: "create comment") and not on the entity directly (comment). An action looks like that:

{
    "user": {
      "id": 2126,
      ...
    },
    "id": 1972,
    "type": 1, // Action type (create, remove, update...etc)
    "entity": 4, // Entity (comment, statement, video...etc)
    "entity_id": 538,
    "time": "2017-11-12T04:26:12.573219",
    "changes": {
      // Changes made with this action
      "text": "I like to move it"
    }
  }

[
  {
    "user": {
      "username": "User-G4R8umEp45",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.569109",
      "picture_url": null,
      "name": "Nella",
      "mini_picture_url": null,
      "id": 2126,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.573219",
    "id": 1972,
    "entity_id": 538,
    "entity": 4,
    "changes": {
      "text": "I like to move it"
    }
  },
  {
    "user": {
      "username": "User-546rUsidyO",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.574333",
      "picture_url": null,
      "name": "Junior",
      "mini_picture_url": null,
      "id": 2128,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.575786",
    "id": 1973,
    "entity_id": 539,
    "entity": 4,
    "changes": {
      "text": "I like to move it"
    }
  },
  {
    "user": {
      "username": "User-VwiSbNEwv-",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.576610",
      "picture_url": null,
      "name": "Patricia",
      "mini_picture_url": null,
      "id": 2130,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.578125",
    "id": 1974,
    "entity_id": 540,
    "entity": 4,
    "changes": {
      "text": "I like to move it"
    }
  },
  {
    "user": {
      "username": "User-GcfGMKNkx7",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.579005",
      "picture_url": null,
      "name": "Abigail",
      "mini_picture_url": null,
      "id": 2132,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.580488",
    "id": 1975,
    "entity_id": 541,
    "entity": 4,
    "changes": {
      "text": "I like to move it"
    }
  },
  {
    "user": {
      "username": "User-JxQBL38e_W",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.581350",
      "picture_url": null,
      "name": "Mason",
      "mini_picture_url": null,
      "id": 2134,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.583214",
    "id": 1976,
    "entity_id": 542,
    "entity": 4,
    "changes": {
      "text": "I like to move it"
    }
  }
]

[
  {
    "user": {
      "username": "User-IVrwM7LAhj",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.519572",
      "picture_url": null,
      "name": "Florencio",
      "mini_picture_url": null,
      "id": 2114,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.521282",
    "id": 1961,
    "entity_id": 535,
    "entity": 4,
    "changes": {
      "text": "Jouje is the best jouje"
    }
  },
  {
    "user": {
      "username": "User-fyflKOAHFL",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.515274",
      "picture_url": null,
      "name": "Rosalyn",
      "mini_picture_url": null,
      "id": 2112,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.517785",
    "id": 1960,
    "entity_id": 534,
    "entity": 4,
    "changes": {
      "text": "I like to move it...."
    }
  },
  {
    "user": {
      "username": "User-MnHUvqvy01",
      "reputation": 0,
      "registered_at": "2017-11-12T04:26:12.523268",
      "picture_url": null,
      "name": "Ora",
      "mini_picture_url": null,
      "id": 2116,
      "achievements": [
        1
      ]
    },
    "type": 1,
    "time": "2017-11-12T04:26:12.524697",
    "id": 1962,
    "entity_id": 536,
    "entity": 4,
    "changes": {
      "text": "No problemo, he said"
    }
  }
]

{
  "value": 1,
  "action_id": 1969
}

Resources

Stackoverflow blog posts about collective moderation:

• https://stackoverflow.blog/2009/05/18/a-theory-of-moderation/
• https://stackoverflow.blog/2010/07/27/moderator-pro-tempore/
• https://stackoverflow.blog/2010/12/02/stack-exchange-moderator-elections-begin/

We must ensure that no library is loading its own React 15 when migrating. Also, there's a chance that some of them will generate warnings; task may include fixing other open source projects.

Benefits

• New return types, including arrays and strings
• Better error handling
• Lighter package (160kb -> 109kb)
• In the future, async rendering

More info here: https://reactjs.org/blog/2017/09/26/react-v16.0.html

Damien Le Boulaire reported that autoscroll doesn't work with freshly added statements.

To Reproduce
Steps to reproduce the behavior:

1. Go to a Video page with some statements already created
2. Create a new statement in the middle of the other
3. Move the video time and ensure it scrolls

System

• OS: Windows 10
• Browser: Google Chrome

See https://developer.mozilla.org/en-US/docs/Archive/Add-ons/Installing_Extensions_and_Themes_From_Web_Pages

We sometimes would like for people to check a statement for us (no time, no experience in the subject...)

Like Stackoverflow with issues, users with high reputation could offer some of this reputation as a bounty on a statement for it to be verified. They then decide of the best response(s?) and user(s?) get a reputation bounty

Rules

• Invested reputation cannot be withdraw; it is lost if not given
• Cannot give bounty to self
• Min bounty ~5pts
• Max bounty ~20pts
• Need to have at least 125 reputation
• Can only place ~10 bounties per day
• Multiple users can place bounties, for a max total of 60pts
• Bounty reward can be split between multiple users

Interface

• Add bounty icon may go to the top right of the statement
• User placing the bounty should be presented a slider or a number input between 5 and 20
• When rewarding, a similar slider set by default to MAX should be presented to select how much we want to give to the user

Contribute

Discussion is open, ideas and coders are welcome 😙

The devDependency browserslist was updated from 4.3.4 to 4.3.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

browserslist is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

reproduced many times.

The main issue : The text is deleted when a user press '<' on speaker name field.

React-select v2 has a cleaner API and lot of improvements. See https://react-select.com/upgrade-guide

As of today we use it in two components:

• In SpeakersSelect.jsx
  Should be straightforward as it just displays a list of speakers names with their pictures.

• In AddSpeakerForm.jsx
  Will be a little more trickier as it supports autocompletion, but new API should really improve the code here.

The dependency phoenix was updated from 1.3.4 to 1.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

phoenix is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

OS: Ubuntu 16.04
Browser: Chromium 61.0.3163.100

Firefox is not affected by this issue. Screenshot is self-explanatory:

This will be useful when playing a video on CaptainFact in background while navigating to another tabs.

• Make favicon blink
• Make a little sound
  • Find something gentle and with a free licence
  • Only trigger if CF tab is not active in browser
  • Add an entry in bubble menu to disable the sound

Possible sounds:

• https://freesound.org/people/SpiceProgram/sounds/399191/
• https://freesound.org/people/jakobhandersen/sounds/181052/
• https://freesound.org/people/kila_vat/sounds/434379/

The next page nav button is disabled whereas I am on the videos first page and there are obviously more videos to show.

Other users don't have the problem and I don't have neither when I am in private browsing.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://captainfact.io
2. Click on the videos icon in the side menu
3. the next page button is disabled

Screenshots

System:

• Mac OS mojave
• chrome
• Version 70.0.3538.110
• uBlock origin

Hi,

I'm facing the same error again "Server connection failed, try refreshing the page". After many refreshing sometime it works, sometine not.

So today I checked the console:

Then the websocket connection seems to fail: "Firefox can not connect to the server at wss: //api.captainfact.io/socket/websocket?token=undefined&vs=2.0.0."

I'm using Ghostery, Ublock, Vimvixen :)

PS: Nice job for the site 😀

Frédéric found a case where a user with a French browser / machine had the interface put in English by default. We need to investigate, reproduce and fix if this is the case.

Automatic language detection is done in https://github.com/CaptainFact/captain-fact-frontend/blob/master/app/i18n/browser_locale.js

Easy feature for anyone who wants to get started on this project: implement a list of all speakers with a nice display and link it to the (currently disabled) sidebar menu entry:

API endpoint to come, feel free to comment if you want to work on this!

Regarding the fact that CaptainFact/captain-fact-api#9 is now implemented, we can easily change the frontend to be able to login with username. There's no change in API, the field email now accept a username to be passed as well.

This issue is really close to what we had with #1

It is most probably introduced by FlipMove whose CSS transitions don't play well with fullscreen. There's no easy fix right now and we can only hope Google will do something on their side.

Comments fullscreen has been disabled for now but is still triggered when double-clicking on video.

Signaled by DocFred

The dependency reactjs-popup was updated from 1.3.1 to 1.3.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

reactjs-popup is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

View details in Rollbar: https://rollbar.com/captainfact/CaptainFact-Frontend/items/11/

ReferenceError: Can't find variable: Audio
  File "https://captainfact.io/app.3fb7c9e1b873908ace53.js", line 1, in [anonymous]

There have been updates to the react monorepo:

• • The dependency react was updated from 16.6.1 to 16.6.2.

• The dependency react-dom was updated from 16.6.1 to 16.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the react group definition.

react is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

We should display thumbnails / players on sources when available.

Should use the existing ReactPlayer component to embed sources from the following providers:

• Youtube
• Facebook
• Soundcloud
• Vimeo
• Dailymotion

Data should never be preloaded, especially if implementing direct file embedding (see ReactPlayer documentation for this part).

1. Click on add statement
2. Set sound volume on the player to a low value (but not muted)
3. Click on left or right caret on the statement to move time position and change play offset

• Effect

Move position and sound volume value is set to maximum

• Expected

Should move position without changing sound volume level

The devDependency webpack was updated from 4.26.1 to 4.27.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Chat button have a double border on the right, we need to hide it.

The dependency redux-actions was updated from 2.6.1 to 2.6.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

redux-actions is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Bug signaled by Timothée Roland (@Presytimi) on the website regarding the scroll bar when over the video module

When trying to compile with brunch 2.10.12, the following error pops out:

09:10:54 - info: compiling
09:10:58 - info: compiling.
/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-map-generator.js:289
      throw new Error('Invalid mapping: ' + JSON.stringify({
      ^

Error: Invalid mapping: {"generated":{"line":574,"column":10},"source":"node_modules/bulma/sass/utilities/controls.sass","original":{"line":26,"column":-1},"name":null}
    at SourceMapGenerator_validateMapping [as _validateMapping] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-map-generator.js:289:13)
    at SourceMapGenerator_addMapping [as addMapping] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-map-generator.js:101:12)
    at /root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-node.js:351:13
    at SourceNode_walk [as walk] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-node.js:230:9)
    at SourceNode_walk [as walk] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-node.js:226:13)
    at SourceNode_walk [as walk] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-node.js:226:13)
    at SourceNode_toStringWithSourceMap [as toStringWithSourceMap] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/node_modules/source-map/lib/source-node.js:342:8)
    at concat (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/fs_utils/generate.js:125:15)
    at generate (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/fs_utils/generate.js:181:14)
    at Promise.all.changed.map.file (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/fs_utils/write.js:166:12)
    at Array.map (native)
    at write (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/fs_utils/write.js:165:30)
    at BrunchWatcher.compile (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/watch.js:293:5)
    at FileList.fileList.on (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/watch.js:154:14)
    at emitNone (events.js:86:13)
    at FileList.emit (events.js:185:7)
    at Timeout.timer.setTimeout [as _onTimeout] (/root/.nvm/versions/node/v6.12.3/lib/node_modules/brunch/lib/fs_utils/file_list.js:171:14)
    at ontimeout (timers.js:386:11)
    at tryOnTimeout (timers.js:250:5)
    at Timer.listOnTimeout (timers.js:214:5)