canopas / compose-recyclerview Goto Github PK

onSwipe lambda is useless, because inside ItemTouchHelper constructor swipeDirs is set to 0, which means that swiping blocked

If you try to update list that contains less elements than previous state - it cause crash. Because totalCount not updated
Example:

1. You have list with 10 elements
2. Not necessary. Add new element into list. Everything ok. List size = 11
3. Remove one element from list. List size = 10. App crash

Looks like we need to change setter of totalCount and add some logic for notifyItemRemoved()
Or another possible solution is to add diff_utils mechanic

First of all, I want to thank you for this nice wrapper around RecyclerView 👏🏻

Secondly, as a new user, the README/documentation of this repository was not very clear in informing me that for drag-and-drop to work, I need to pass in an object of ComposeRecyclerViewAdapter.ItemTypeBuilder. I had to figure it out by trial and error.

Therefore, to make it easier for future users to get started easily, I'd request you to either mention the fact above, or better yet, instead of using null as the default value for the itemTypeBuilder param in ComposeRecyclerView, give it a default non-null value that allows drag-and-drop by default.

For example:

private val DefaultItemTypeBuilder = object : ComposeRecyclerViewAdapter.ItemTypeBuilder {
    override fun getItemType(position: Int): Int = 0
}

// Rest of the code
// Mention that in order to remove drag-and-drop, users would need to pass `null` into this param
itemTypeBuilder: ComposeRecyclerViewAdapter.ItemTypeBuilder = DefaultItemTypeBuilder,
// Rest of the code